You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/23 14:47:05 UTC

[GitHub] [flink] azagrebin opened a new pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

azagrebin opened a new pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934
 
 
   ## What is the purpose of the change
   
   RocksDB compaction filter is always enabled by default after #10866 and we deprecated its disabling. The docs should not refer to its enabling/disabling. The Chinese translation still has to be adjusted separately.
   
   ## Brief change log
   
   adjust `state.md`
   
   ## Verifying this change
   
   doc change
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934#discussion_r370166970
 
 

 ##########
 File path: docs/dev/stream/state/state.md
 ##########
 @@ -511,7 +508,7 @@ You can change it and pass a custom value to
 `StateTtlConfig.newBuilder(...).cleanupInRocksdbCompactFilter(long queryTimeAfterNumEntries)` method. 
 Updating the timestamp more often can improve cleanup speed 
 but it decreases compaction performance because it uses JNI call from native code.
-If you enable the default background cleanup then this strategy will be activated for RocksDB backend and the current timestamp will be queried each time 1000 entries have been processed.
+The default background cleanup for RocksDB backend queries the current timestamp each time when 1000 entries have been processed.
 
 Review comment:
   Imo, _"when"_ is not needed. 
   
   Maybe another alternative that sounds better to me: _[...] queries the current timestamp for every 1000 processed entries_

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] azagrebin commented on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
azagrebin commented on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934#issuecomment-578079869
 
 
   Thanks for the review @GJL 
   I addressed the comments, merging this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934#issuecomment-577727721
 
 
   <!--
   Meta data
   Hash:04f05418536e63811ba5ac63aa53b915901001de Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:04f05418536e63811ba5ac63aa53b915901001de
   -->
   ## CI report:
   
   * 04f05418536e63811ba5ac63aa53b915901001de UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934#discussion_r370171210
 
 

 ##########
 File path: docs/dev/stream/state/state.md
 ##########
 @@ -471,15 +471,12 @@ e.g. after restart from savepoint.
 
 ##### Cleanup during RocksDB compaction
 
-If RocksDB state backend is used, another cleanup strategy is to activate Flink specific compaction filter.
+If RocksDB state backend is used, another cleanup strategy is to call Flink specific compaction filter.
 
 Review comment:
   Currently it sounds like that the cleanup strategy won't be active by default or there are other strategies that can be used – Maybe that's just me. My proposal would be:
   
   > If the RocksDB state backend is used, a Flink specific compaction filter will be employed to enable background cleanup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934#issuecomment-577714331
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7ac38023d2ca444664f18f53b3b8b15fd5da68db (Thu Jan 23 14:50:39 UTC 2020)
   
   **Warnings:**
    * Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934#issuecomment-577727721
 
 
   <!--
   Meta data
   Hash:04f05418536e63811ba5ac63aa53b915901001de Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145779731 TriggerType:PUSH TriggerID:04f05418536e63811ba5ac63aa53b915901001de
   Hash:04f05418536e63811ba5ac63aa53b915901001de Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4583 TriggerType:PUSH TriggerID:04f05418536e63811ba5ac63aa53b915901001de
   -->
   ## CI report:
   
   * 04f05418536e63811ba5ac63aa53b915901001de Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145779731) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4583) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] azagrebin commented on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
azagrebin commented on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934#issuecomment-578080797
 
 
   merge into master by 05bddfbb90b968f580a181e09144e5dace07dc18
   merge into 1.10 by 52a7ac9d66312d462af3ea5dd4ec607e0dcea6de

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] azagrebin closed pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
azagrebin closed pull request #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10934: [FLINK-15741][docs][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/10934#issuecomment-577727721
 
 
   <!--
   Meta data
   Hash:04f05418536e63811ba5ac63aa53b915901001de Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145779731 TriggerType:PUSH TriggerID:04f05418536e63811ba5ac63aa53b915901001de
   Hash:04f05418536e63811ba5ac63aa53b915901001de Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4583 TriggerType:PUSH TriggerID:04f05418536e63811ba5ac63aa53b915901001de
   -->
   ## CI report:
   
   * 04f05418536e63811ba5ac63aa53b915901001de Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145779731) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4583) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services