You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "T Jake Luciani (JIRA)" <ji...@apache.org> on 2011/06/20 21:56:47 UTC
[jira] [Created] (HADOOP-7408) Add javadoc for SnappyCodec
Add javadoc for SnappyCodec
---------------------------
Key: HADOOP-7408
URL: https://issues.apache.org/jira/browse/HADOOP-7408
Project: Hadoop Common
Issue Type: Bug
Components: io
Reporter: T Jake Luciani
Priority: Trivial
Fix For: 0.23.0
HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7408) Add javadoc for SnappyCodec
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated HADOOP-7408:
-----------------------------------
Attachment: v1-HADOOP-7408-add-snappy-javadoc.txt
> Add javadoc for SnappyCodec
> ---------------------------
>
> Key: HADOOP-7408
> URL: https://issues.apache.org/jira/browse/HADOOP-7408
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: T Jake Luciani
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: v1-HADOOP-7408-add-snappy-javadoc.txt
>
>
> HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7408) Add javadoc for SnappyCodec
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052315#comment-13052315 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7408:
------------------------------------------------
Why passing conf to the following method?
{code}
public static boolean isNativeSnappyLoaded(Configuration conf) {
return nativeSnappyLoaded;
}
{code}
How about remove {{isNativeSnappyLoaded(..)}} and change {{nativeSnappyLoaded}} to final?
> Add javadoc for SnappyCodec
> ---------------------------
>
> Key: HADOOP-7408
> URL: https://issues.apache.org/jira/browse/HADOOP-7408
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7408.patch, v1-HADOOP-7408-add-snappy-javadoc.txt
>
>
> HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7408) Add javadoc for SnappyCodec
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7408:
-------------------------------------------
Status: Open (was: Patch Available)
> Add javadoc for SnappyCodec
> ---------------------------
>
> Key: HADOOP-7408
> URL: https://issues.apache.org/jira/browse/HADOOP-7408
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7408.patch, v1-HADOOP-7408-add-snappy-javadoc.txt
>
>
> HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7408) Add javadoc for SnappyCodec
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052242#comment-13052242 ]
Hadoop QA commented on HADOOP-7408:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483211/HADOOP-7408.patch
against trunk revision 1137724.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/659//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/659//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/659//console
This message is automatically generated.
> Add javadoc for SnappyCodec
> ---------------------------
>
> Key: HADOOP-7408
> URL: https://issues.apache.org/jira/browse/HADOOP-7408
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7408.patch, v1-HADOOP-7408-add-snappy-javadoc.txt
>
>
> HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7408) Add javadoc for SnappyCodec
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated HADOOP-7408:
-----------------------------------
Assignee: T Jake Luciani
Status: Patch Available (was: Open)
> Add javadoc for SnappyCodec
> ---------------------------
>
> Key: HADOOP-7408
> URL: https://issues.apache.org/jira/browse/HADOOP-7408
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: v1-HADOOP-7408-add-snappy-javadoc.txt
>
>
> HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7408) Add javadoc for SnappyCodec
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052201#comment-13052201 ]
Hadoop QA commented on HADOOP-7408:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483200/v1-HADOOP-7408-add-snappy-javadoc.txt
against trunk revision 1137724.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/657//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/657//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/657//console
This message is automatically generated.
> Add javadoc for SnappyCodec
> ---------------------------
>
> Key: HADOOP-7408
> URL: https://issues.apache.org/jira/browse/HADOOP-7408
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: v1-HADOOP-7408-add-snappy-javadoc.txt
>
>
> HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7408) Add javadoc for SnappyCodec
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-7408:
------------------------------
Attachment: HADOOP-7408.patch
Looks good. I've updated your patch to annotate SnappyCodec as public evolving (like the other codecs in the package), and to provide a link to the snappy homepage from this class.
> Add javadoc for SnappyCodec
> ---------------------------
>
> Key: HADOOP-7408
> URL: https://issues.apache.org/jira/browse/HADOOP-7408
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7408.patch, v1-HADOOP-7408-add-snappy-javadoc.txt
>
>
> HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7408) Add javadoc for SnappyCodec
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052318#comment-13052318 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7408:
------------------------------------------------
Also, could you add {{@Override}} for overriding methods?
> Add javadoc for SnappyCodec
> ---------------------------
>
> Key: HADOOP-7408
> URL: https://issues.apache.org/jira/browse/HADOOP-7408
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7408.patch, v1-HADOOP-7408-add-snappy-javadoc.txt
>
>
> HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-7408) Add javadoc for SnappyCodec
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HADOOP-7408.
--------------------------------------------
Resolution: Not A Problem
Fix Version/s: (was: 0.23.0)
It turns out that we have to revert HADOOP-7206. So this is not a problem anymore.
> Add javadoc for SnappyCodec
> ---------------------------
>
> Key: HADOOP-7408
> URL: https://issues.apache.org/jira/browse/HADOOP-7408
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Priority: Trivial
> Attachments: HADOOP-7408.patch, v1-HADOOP-7408-add-snappy-javadoc.txt
>
>
> HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7408) Add javadoc for SnappyCodec
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052290#comment-13052290 ]
T Jake Luciani commented on HADOOP-7408:
----------------------------------------
+1
> Add javadoc for SnappyCodec
> ---------------------------
>
> Key: HADOOP-7408
> URL: https://issues.apache.org/jira/browse/HADOOP-7408
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Priority: Trivial
> Fix For: 0.23.0
>
> Attachments: HADOOP-7408.patch, v1-HADOOP-7408-add-snappy-javadoc.txt
>
>
> HADOOP-7206 failed to include a javadoc for public methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira