You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/04 11:22:51 UTC
[GitHub] [zookeeper] ztzg opened a new pull request #1591: ZOOKEEPER-4199: Avoid thread leak in QuorumRequestPipelineTest
ztzg opened a new pull request #1591:
URL: https://github.com/apache/zookeeper/pull/1591
`QuorumRequestPipelineTest` hosts parameterized tests which explicitly call `QuorumBase.setUp(boolean)`.
This patch overrides the argument-less `QuorumBase.setUp()` with an empty body, as the former is annotated `@BeforeEach`—otherwise causing the runtime to start a fresh 5-ensemble before each test.
Without the override, one such extraneous ensemble is created and immediately leaked for each combination of test method + parameters.
The test consequently requires 4000+ simultaneous threads to complete, and while Linux happily handles that load, macOS Catalina's per-process limit of 2048 threads effectively causes the JVM to "crash" or lock up.
The solution is copied verbatim from another parameterized subclass of `QuorumBase`, `EagerACLFilterTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1591: ZOOKEEPER-4199: Avoid thread leak in QuorumRequestPipelineTest
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1591:
URL: https://github.com/apache/zookeeper/pull/1591#issuecomment-792044123
Now also in `branch-3.7` and `branch-3.7.0`. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1591: ZOOKEEPER-4199: Avoid thread leak in QuorumRequestPipelineTest
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1591:
URL: https://github.com/apache/zookeeper/pull/1591#issuecomment-773235799
Cc: @tamaashu.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1591: ZOOKEEPER-4199: Avoid thread leak in QuorumRequestPipelineTest
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1591:
URL: https://github.com/apache/zookeeper/pull/1591#issuecomment-792518988
thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1591: ZOOKEEPER-4199: Avoid thread leak in QuorumRequestPipelineTest
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1591:
URL: https://github.com/apache/zookeeper/pull/1591#issuecomment-781151848
sure, I'll merge soon, thanks @ztzg !!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1591: ZOOKEEPER-4199: Avoid thread leak in QuorumRequestPipelineTest
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1591:
URL: https://github.com/apache/zookeeper/pull/1591#issuecomment-773235799
Cc: @tamaashu.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1591: ZOOKEEPER-4199: Avoid thread leak in QuorumRequestPipelineTest
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1591:
URL: https://github.com/apache/zookeeper/pull/1591#issuecomment-780900155
@eolivelli, @symat: Great CI success! Would one of you mind merging this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1591: ZOOKEEPER-4199: Avoid thread leak in QuorumRequestPipelineTest
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1591:
URL: https://github.com/apache/zookeeper/pull/1591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org