[GitHub] [ozone] lokeshj1703 commented on a change in pull request #1604: HDDS-4356. SCM is flooded with useless "Deleting blocks" messages.

[GitBox <gi...@apache.org>]

lokeshj1703 commented on a change in pull request #1604:
URL: https://github.com/apache/ozone/pull/1604#discussion_r529514509



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java
##########
@@ -129,9 +129,12 @@ public void incrementCount(List<Long> txIDs) throws IOException {
         DeletedBlocksTransaction block =
             scmMetadataStore.getDeletedBlocksTXTable().get(txID);
         if (block == null) {
-          // Should we make this an error ? How can we not find the deleted
-          // TXID?
-          LOG.warn("Deleted TXID {} not found.", txID);

Review comment:
       @xiaoyuyao I can see this warning message being printed a lot of times during deletion. It can easily fill up SCM log during deletion. How about we change the log level and investigate the reason in a separate jira?
   Since SCM is processing thousand of transactions and it resends these transactions to a particular datanode. Then this log can be printed thousands of times.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org