You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/25 14:30:11 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #11836: Add flower authentication

mik-laj commented on a change in pull request #11836:
URL: https://github.com/apache/airflow/pull/11836#discussion_r511604307



##########
File path: chart/templates/_helpers.yaml
##########
@@ -49,6 +49,13 @@
       secretKeyRef:
         name: {{ .Release.Name }}-broker-url
         key: connection
+  {{- if .Values.flower.basicAuth}}

Review comment:
       It doesn't look very safe. Only the flower container should have access to this secret, and in particular the worker should NOT be able to access this secret.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org