[jira] [Commented] (CASSANDRA-18364) CEP-15: (C*) Accord message processing should avoid being passed on to a Stage and run directly in the messageing handler

["David Capwell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-18364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707344#comment-17707344 ] 

David Capwell commented on CASSANDRA-18364:
-------------------------------------------

Ran the cluster benchmarks with this patch and with the following Splunk filter we have a clean result

{code}
exception!="*Inconsistent execution timestamp detected for txnId*"
exception!="*Unexpected state FINISHED*AsyncOperation.fail(AsyncOperation.java:182)*"
exception!="*Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP*"
exception!="java.lang.NullPointerException*accord.topology.TopologyManager.localForEpoch(TopologyManager.java:402)*"
exception!="java.lang.NullPointerException*TxnData.java:45*"
exception!="*org.apache.cassandra.service.ActiveRepairService*"
{code}

I pushed a fix for "exception!="java.lang.NullPointerException*TxnData.java:45*"" as it was us not handling the null case.  

> CEP-15: (C*) Accord message processing should avoid being passed on to a Stage and run directly in the messageing handler
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18364
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18364
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Accord
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 5.x
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Accord message processing should avoid being passed on to a Stage and run directly in the messageing handler.  This logic should validate that all messages are non-blocking and async handle replies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org