You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2012/05/17 22:01:52 UTC

svn commit: r1339831 - in /hbase/trunk: conf/hadoop-metrics.properties src/site/xdoc/metrics.xml

Author: stack
Date: Thu May 17 20:01:51 2012
New Revision: 1339831

URL: http://svn.apache.org/viewvc?rev=1339831&view=rev
Log:
HBASE-5802 Change the default metrics class to NullContextWithUpdateThread

Modified:
    hbase/trunk/conf/hadoop-metrics.properties
    hbase/trunk/src/site/xdoc/metrics.xml

Modified: hbase/trunk/conf/hadoop-metrics.properties
URL: http://svn.apache.org/viewvc/hbase/trunk/conf/hadoop-metrics.properties?rev=1339831&r1=1339830&r2=1339831&view=diff
==============================================================================
--- hbase/trunk/conf/hadoop-metrics.properties (original)
+++ hbase/trunk/conf/hadoop-metrics.properties Thu May 17 20:01:51 2012
@@ -10,12 +10,15 @@
 # GMETADHOST_IP is the hostname (or) IP address of the server on which the ganglia 
 # meta daemon (gmetad) service is running
 
-# Configuration of the "hbase" context for null
-hbase.class=org.apache.hadoop.metrics.spi.NullContext
+# Configuration of the "hbase" context for NullContextWithUpdateThread
+# NullContextWithUpdateThread is a  null context which has a thread calling
+# periodically when monitoring is started. This keeps the data sampled
+# correctly.
+hbase.class=org.apache.hadoop.metrics.spi.NullContextWithUpdateThread
+hbase.period=10
 
 # Configuration of the "hbase" context for file
 # hbase.class=org.apache.hadoop.hbase.metrics.file.TimeStampingFileContext
-# hbase.period=10
 # hbase.fileName=/tmp/metrics_hbase.log
 
 # HBase-specific configuration to reset long-running stats (e.g. compactions)
@@ -30,11 +33,11 @@ hbase.extendedperiod = 3600
 # hbase.servers=GMETADHOST_IP:8649
 
 # Configuration of the "jvm" context for null
-jvm.class=org.apache.hadoop.metrics.spi.NullContext
+jvm.class=org.apache.hadoop.metrics.spi.NullContextWithUpdateThread
+jvm.period=10
 
 # Configuration of the "jvm" context for file
 # jvm.class=org.apache.hadoop.hbase.metrics.file.TimeStampingFileContext
-# jvm.period=10
 # jvm.fileName=/tmp/metrics_jvm.log
 
 # Configuration of the "jvm" context for ganglia
@@ -45,11 +48,11 @@ jvm.class=org.apache.hadoop.metrics.spi.
 # jvm.servers=GMETADHOST_IP:8649
 
 # Configuration of the "rpc" context for null
-rpc.class=org.apache.hadoop.metrics.spi.NullContext
+rpc.class=org.apache.hadoop.metrics.spi.NullContextWithUpdateThread
+rpc.period=10
 
 # Configuration of the "rpc" context for file
 # rpc.class=org.apache.hadoop.hbase.metrics.file.TimeStampingFileContext
-# rpc.period=10
 # rpc.fileName=/tmp/metrics_rpc.log
 
 # Configuration of the "rpc" context for ganglia

Modified: hbase/trunk/src/site/xdoc/metrics.xml
URL: http://svn.apache.org/viewvc/hbase/trunk/src/site/xdoc/metrics.xml?rev=1339831&r1=1339830&r2=1339831&view=diff
==============================================================================
--- hbase/trunk/src/site/xdoc/metrics.xml (original)
+++ hbase/trunk/src/site/xdoc/metrics.xml Thu May 17 20:01:51 2012
@@ -69,8 +69,8 @@
       <p>
       To enable JMX support in HBase, first edit 
       <code>$HBASE_HOME/conf/hadoop-metrics.properties</code> to support 
-      metrics refreshing. (If you've already configured 
-      <code>hadoop-metrics.properties</code> for another output context, 
+      metrics refreshing. (If you've running 0.94.1 and above, or have already configured 
+      <code>hadoop-metrics.properties</code> for another output context,
       you can skip this step).
       </p>
       <source>