You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "eric-wang-1990 (via GitHub)" <gi...@apache.org> on 2025/11/04 09:55:34 UTC
[PR] feat(csharp/Benchmarks): Add .NET Framework 4.7.2 support with TLS co… [arrow-adbc]
eric-wang-1990 opened a new pull request, #3682:
URL: https://github.com/apache/arrow-adbc/pull/3682
…nfiguration
This commit enhances the CloudFetch benchmark suite to support testing on .NET Framework 4.7.2, which is the runtime used by Power BI.
Changes:
- Add net472 target framework to Benchmarks.csproj
- Make Tests project reference conditional (net8.0 only, since Tests doesn't support net472)
- Enable TLS 1.2/1.3 in CloudFetchBenchmarkRunner for .NET Framework
- Enable TLS 1.2/1.3 in benchmark GlobalSetup for spawned processes
These changes are necessary because .NET Framework 4.7.2 doesn't enable modern TLS protocols by default, which are required for Databricks HTTPS connections. This allows accurate performance testing on the Power BI runtime environment (net472 with DefaultArrayPool).
Sample output:
| Method | ReadDelayMs | Mean | Min | Max | Median | Peak Memory (MB) | Total Rows | Total Batches | Gen0 | Gen1 | Gen2 | Allocated |
|------------------ |------------ |--------:|--------:|--------:|--------:|-----------------:|-----------:|--------------:|------------:|-----------:|-----------:|----------:|
| ExecuteLargeQuery | 5 | 9.659 s | 9.016 s | 10.03 s | 9.928 s | 356.38 | 1,439,935 | 740 | 336000.0000 | 57000.0000 | 35000.0000 | 2.73 GB |
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp/Benchmarks): Add .NET Framework 4.7.2 support with TLS co… [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on code in PR #3682:
URL: https://github.com/apache/arrow-adbc/pull/3682#discussion_r2491357936
##########
csharp/Benchmarks/Benchmarks.csproj:
##########
@@ -23,6 +23,9 @@
<ProjectReference Include="..\src\Apache.Arrow.Adbc\Apache.Arrow.Adbc.csproj" />
<ProjectReference Include="..\src\Client\Apache.Arrow.Adbc.Client.csproj" />
<ProjectReference Include="..\src\Drivers\Databricks\Apache.Arrow.Adbc.Drivers.Databricks.csproj" />
+ </ItemGroup>
+
+ <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
Review Comment:
The issue here is that .NET 4.7.2 is not supported on non-Windows platforms, so the project Apache.Arrow.Adbc.Tests only targets it on Windows. Instead of having a conditional here on the `TargetFramework` we could follow the same pattern for the project as a whole and define `TargetFrameworks` as
```
<TargetFrameworks Condition="'$(IsWindows)'=='true'">net8.0;net472</TargetFrameworks>
<TargetFrameworks Condition="'$(TargetFrameworks)'==''">net8.0</TargetFrameworks>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp/Benchmarks): Add .NET Framework 4.7.2 support with TLS co… [arrow-adbc]
Posted by "eric-wang-1990 (via GitHub)" <gi...@apache.org>.
eric-wang-1990 commented on code in PR #3682:
URL: https://github.com/apache/arrow-adbc/pull/3682#discussion_r2492303212
##########
csharp/Benchmarks/Program.cs:
##########
@@ -15,12 +15,15 @@
* limitations under the License.
*/
+#if NET8_0
Review Comment:
Not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp/Benchmarks): Add .NET Framework 4.7.2 support with TLS co… [arrow-adbc]
Posted by "eric-wang-1990 (via GitHub)" <gi...@apache.org>.
eric-wang-1990 commented on code in PR #3682:
URL: https://github.com/apache/arrow-adbc/pull/3682#discussion_r2492164348
##########
csharp/Benchmarks/Benchmarks.csproj:
##########
@@ -23,6 +23,9 @@
<ProjectReference Include="..\src\Apache.Arrow.Adbc\Apache.Arrow.Adbc.csproj" />
<ProjectReference Include="..\src\Client\Apache.Arrow.Adbc.Client.csproj" />
<ProjectReference Include="..\src\Drivers\Databricks\Apache.Arrow.Adbc.Drivers.Databricks.csproj" />
+ </ItemGroup>
+
+ <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp/Benchmarks): Add .NET Framework 4.7.2 support with TLS co… [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on code in PR #3682:
URL: https://github.com/apache/arrow-adbc/pull/3682#discussion_r2492232497
##########
csharp/Benchmarks/Program.cs:
##########
@@ -15,12 +15,15 @@
* limitations under the License.
*/
+#if NET8_0
Review Comment:
Do we still need the `#ifs` in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp/Benchmarks): Add .NET Framework 4.7.2 support with TLS co… [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #3682:
URL: https://github.com/apache/arrow-adbc/pull/3682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org