[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #5024: Micrometer: SimpleMeterRegistry is not created if no other registry is defined #5023

["JiriOndrusek (via GitHub)" <gi...@apache.org>]

JiriOndrusek commented on PR #5024:
URL: https://github.com/apache/camel-quarkus/pull/5024#issuecomment-1612517525

   > I wonder if we should avoid extending the component?
   > 
   > And instead consume `List<MicrometerRegistryProviderBuildItem>`. And if it's empty, then we can just register `SimpleMeterRegistry` with the existing Quarkus composite registry (which has its own `BuildItem` where the value can be passed to a recorder).
   > 
   > I'm just thinking out loud, not sure if that would work or not.
   
   This is a nice idea. Registering simpleRegistry and keeping the Quarks mechanism working as expected should be nice and it would allow to share SimpleRegistry among more services/apps/beans. I'll try that solution.
   
   and thanks for the founded issues in the code , I'll rework the PR with this new approach to see if it works as expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org