[jira] [Comment Edited] (ARIES-1710) Configurable enable-annotation element in blueprint xml

["Dominik Przybysz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIES-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955810#comment-15955810 ] 

Dominik Przybysz edited comment on ARIES-1710 at 4/4/17 9:10 PM:
-----------------------------------------------------------------

Ad 2) If you use Transactional annotation then it always should generate enable element for namespace 2.0.0. If you do not want to use transactions, then remove annotation.

Ad 3) I think we should go with maven standards: if this parameter is java boolean underhood, then it should also look like a java boolean. https://maven.apache.org/guides/plugin/guide-java-plugin-development.html (search for first occurrence of "boolean"). If people see sometimes "0", sometimes "true", then they also ask why "yes" does not work.


was (Author: alien11689):
Ad 2) If you use Transactional annotation then it always should generate enable element for namespace 2.0.0. If you do not want to use transactions, then remove annotation.

Ad 3) I think we should go with maven standards: if this parameter is java boolean underhood, then it should also look like a java boolean. https://maven.apache.org/guides/plugin/guide-java-plugin-development.html If people see sometimes "0", sometimes "true", then they also ask why "yes" does not work.

> Configurable enable-annotation element in blueprint xml
> -------------------------------------------------------
>
>                 Key: ARIES-1710
>                 URL: https://issues.apache.org/jira/browse/ARIES-1710
>             Project: Aries
>          Issue Type: Improvement
>          Components: Blueprint
>    Affects Versions: blueprint-maven-plugin-1.6.0
>            Reporter: Andrei Shakirin
>            Assignee: Christian Schneider
>         Attachments: blueprint-maven-plugin.patch
>
>
> Currently tx:enable-annotation element is always added for 1.0.0, 1.1.0, 1.2.0 and 2.0.0 transaction namespaces by blueprint-plugin.
> This element enables scanning of @Transactional attribute in beans additionally to blueprint configuration
> Problems:
> 1) 1.0.0 and 1.1.0 schemas doesn't support this element at all
> 2) for 1.2.0 there are use cases to skip annotation scanning and use only configured transaction attributes in xml
> Proposal:
> 1) enable element only for 1.2.0 and 2.0.0 namespaces
> 2) provide configuration property to deactivate injection of this element



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)