You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jake Farrell <jf...@apache.org> on 2018/04/03 14:12:32 UTC
[RESULT][VOTE]: Move from legacy asf git to Apache GitBox
result vote never sent for this, closing it out.
With 6 positive votes (4 binding, 2 non binding), and zero negative votes
the vote to move to Apache GitBox for core development passes. I'll submit
the request and keep everyone updated as INFRA moves us over
-Jake
Binding positive votes:
Randy Abernethy
Jake Farrell
James King
Aki Sukegawa
Non Binding positive votes:
Duru Can Celasun
Wang Xin
On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <jk...@apache.org>
wrote:
> Apache GitBox provides the Thrift project more control over the lifecycle
> of pull requests and improve the team's ability to get things done in a
> timely manner. The goal is to improve team self-service in GitHub and
> integrated CI workflows. One important improvement for committers is that
> it allows them to "Rebase and Merge" directly in GitHub, assuming the
> commit description meets published guidelines. It also allows for more
> control over GitHub features such as issues (note there are no plans to
> switch from Apache Hira to GitHub Issues right now), and it allows pull
> requests to be assigned to committers and labelled.
>
> I found one discussion link for reference from another Apache project
> considering conversion back in July 2017:
>
> http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> Gitbox-td18273.html
>
> Please VOTE:
>
> [ ] +1 Move to Apache GitBox
> [ ] +0
> [ ] -1 Don't move to Apache GitBox because...
>
> Voting will end in 72 hours (excluding the weekend), March 26, 2018 at
> 9:00:00 AM EDT
> https://www.timeanddate.com/countdown/to?iso=20180326T09
>
> - Jim King (PMC Member)
>
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by "James E. King, III" <jk...@apache.org>.
The boost project handles release notes (major changes, breaking changes,
and issue fixed) by requiring each repository maintainer to modify a shared
documentation file (using github). It isn't perfect but it allows for the
important bugfixes and breaking changes to be identified. In general
people are pretty good at spotting breaking changes here and requiring pull
requests to update the language-specific README.md file with breaking
changes. If you look at the lib/perl/README.md file for example I made
breaking changes in 0.10.0 and 0.11.0 however I also provided simple
workaround that allow someone to write thrift code that works with older or
newer thrift libraries (for projects in transition, this is typically
useful). It was my assumption that the language-specific readme files were
sufficient to communicate breaking changes.
On the issue of golang, the golang project only supports one major release
back, so right now 1.10 is current and 1.9 is supported, but 1.8 is no
longer supported. We should follow suit, and that means we don't need the
1.6 to 1.7 context conversion stuff. If folks still need 1.6 or 1.7
support they can run an already-released version of thrift, and begin
making plans to modernize their go and their thrift in a future release.
It looks like the go build issue has been resolved.
Thanks,
Jim
On Fri, Apr 6, 2018 at 8:46 AM, Duru Can Celasun <dc...@apache.org>
wrote:
> I agree with points 1, 2 and migrating the website to Github.
>
> For 3, if an issue number is required but missing, we should ask the
> author to amend their commit. But we should also be willing to edit locally
> if needed. Closing a PR for commit format issues would discourage first
> time contributors.
>
> For 4, it might be a good idea to have a manually created changelog and
> require everyone to add a line there for non-trivial changes. This would
> make the changelog much more readable and flexible, like adding examples if
> there is a BC break etc.
>
> - Can
>
> On Fri, 6 Apr 2018, at 14:10, James E. King, III wrote:
> > Great!
> >
> > There was a complaint that the CHANGES file has no 0.11.0 data in it from
> > the user/dev mailing lists.
> > I will open a Jira ticket for that. Let's also make sure it's in the
> "how
> > to release" directions.
> >
> > I assume that going forward we are going to continue to require Jira
> > tickets because that is how
> > we generate the CHANGES content. True? Even for simple changes? I
> would
> > like to make it
> > earier for the project to accept documentation, website, and build script
> > changes without needing
> > the heavy weight of a ticket.
> >
> > Also see https://github.com/apache/thrift/pull/1531 for example. It is
> a
> > very simple bugfix. Now on
> > one hand if we don't have a Jira ticket someone cannot search to find the
> > "known" issue if they need to.
> > On the other hand, our Jira open backlog is tremendously large and folks
> > might have trouble finding
> > the issue anyway.
> >
> > So I would like to ask for a discussion about:
> >
> > 1. No longer requiring the "Client" tag for a check-in.
> > 2. No longer needing a Jira thrift ticket for comment-only, doc, website,
> > or simple build script changes.
> > 3. Now that we can click "rebase and merge" directly on github, but we
> > don't have the ability to change
> > the commit message, do we simply reject any PR that requires a Jira
> ticket
> > but doesn't have the Jira
> > ticket ID in the commit message?
> > 4. Do we still want the weight of a Jira ticket for simplistic code
> > changes? See this one for an example
> > of a simple change. Does it need the full weight of a Jira ticket?
> > https://github.com/apache/thrift/pull/1531/
> > I suppose if we don't have a Jira ticket we cannot generate CHANGES that
> > identify it. Is the CHANGES
> > file that useful in its current form?
> >
> > To these ends I can commit a markdown file that github will display on
> > every pull request indicating some
> > guidelines people should follow. I will start on one now that follows
> our
> > current rules of requiring a jira ticket
> > for everything.
> >
> > Goal is to get to the point where we can literally have people get their
> > PRs right the first time, and get
> > the CI build to pass, and then click "Rebase and Merge". (We only want
> to
> > use rebase and merge to
> > avoid merge commits). We want it to be easy to submit changes, easy to
> > commit the changes, with
> > sufficient information to generate release notes.
> >
> > Finally, can we move the thrift website into github and out of Apache CMS
> > somehow?
> > This would make it vastly easier to update the website.
> >
> > - Jim
> >
> >
> > On Fri, Apr 6, 2018 at 7:49 AM, Duru Can Celasun <dc...@apache.org>
> > wrote:
> >
> > > INFRA just added a redirect from git.a.o to Github, which works well
> for
> > > me. I think this solves the immediate problem.
> > >
> > > On Fri, 6 Apr 2018, at 13:41, James E. King, III wrote:
> > > > The INFRA team will not migrate back. We should be able to
> re-release
> > > > package-specific distributions of a given version to resolve.
> > > > Or, release 0.12.0 with the correct URLs ASAP. (I like that idea)
> > > >
> > > > Now it would be nice if I could commit pull requests online rather
> than
> > > > having to do it from the command line, but the commit buttons are not
> > > > enabled for me on github.
> > > > It looks like I can commit PRs however.
> > > >
> > > > - Jim
> > > >
> > > > On Fri, Apr 6, 2018 at 1:19 AM, Duru Can Celasun <
> dcelasun@apache.org>
> > > > wrote:
> > > >
> > > > > Per THRIFT-4542, it seems there is no workaround INFRA can do to
> place
> > > a
> > > > > mirror or snapshot on git.a.o
> > > > >
> > > > > For most languages that are effected by this, a single line change
> in
> > > the
> > > > > dependency manifest might be enough to fix this (there is a PHP
> > > example in
> > > > > Jira).
> > > > > Unfortunately for us, Go uses the full package path with git.a.o in
> > > import
> > > > > statements, so there is no easy solution. I'll copy my suggestion
> from
> > > Jira
> > > > > below:
> > > > >
> > > > > - Revert GitBox migration and restore git.a.o
> > > > > - Update all URLs (code & docs) to use Github instead of git.a.o
> > > > > - Release 0.12 as soon as we can, hopefully sooner rather than
> later
> > > > > - Wait a reasonable amount of time so users have a chance to
> upgrade
> > > > > - Switch to GitBox once again
> > > > >
> > > > > While this is definitely not ideal, I can't see a viable
> alternative.
> > > > >
> > > > > - Can
> > > > >
> > > > > On Fri, 6 Apr 2018, at 06:39, James E. King, III wrote:
> > > > > > Transition to GitBox is complete. The older asf repository is no
> > > longer
> > > > > > accessible.
> > > > > > Removal of the older git repository has broken a number of
> language
> > > > > > packages.
> > > > > > Folks are complaining about this and we need to do whatever we
> can
> > > to fix
> > > > > > it.
> > > > > > This was unexpected as part of the migration.
> > > > > >
> > > > > > Transition ticket: https://issues.apache.org/
> jira/browse/INFRA-16287
> > > > > >
> > > > > > All thrift committers should go to https://gitbox.apache.org/
> setup/
> > > and
> > > > > > link your account.
> > > > > > Write access is not granted immediately. I don't know how long
> it
> > > takes
> > > > > to
> > > > > > sync.
> > > > > > Hopefully in the morning I will have write access.
> > > > > >
> > > > > > With this conversion it means our github repository is now the
> master
> > > > > > repository for thrift.
> > > > > > Our documentation for developers needs to be updated to reflect
> this.
> > > > > >
> > > > > > - Jim
> > > > > >
> > > > > > On Tue, Apr 3, 2018 at 10:12 AM, Jake Farrell <
> jfarrell@apache.org>
> > > > > wrote:
> > > > > >
> > > > > > > result vote never sent for this, closing it out.
> > > > > > >
> > > > > > > With 6 positive votes (4 binding, 2 non binding), and zero
> negative
> > > > > votes
> > > > > > > the vote to move to Apache GitBox for core development passes.
> I'll
> > > > > submit
> > > > > > > the request and keep everyone updated as INFRA moves us over
> > > > > > >
> > > > > > > -Jake
> > > > > > >
> > > > > > >
> > > > > > > Binding positive votes:
> > > > > > > Randy Abernethy
> > > > > > > Jake Farrell
> > > > > > > James King
> > > > > > > Aki Sukegawa
> > > > > > >
> > > > > > > Non Binding positive votes:
> > > > > > > Duru Can Celasun
> > > > > > > Wang Xin
> > > > > > >
> > > > > > >
> > > > > > > On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <
> > > jking@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Apache GitBox provides the Thrift project more control over
> the
> > > > > lifecycle
> > > > > > > > of pull requests and improve the team's ability to get things
> > > done
> > > > > in a
> > > > > > > > timely manner. The goal is to improve team self-service in
> > > GitHub
> > > > > and
> > > > > > > > integrated CI workflows. One important improvement for
> > > committers is
> > > > > > > that
> > > > > > > > it allows them to "Rebase and Merge" directly in GitHub,
> > > assuming the
> > > > > > > > commit description meets published guidelines. It also
> allows
> > > for
> > > > > more
> > > > > > > > control over GitHub features such as issues (note there are
> no
> > > plans
> > > > > to
> > > > > > > > switch from Apache Hira to GitHub Issues right now), and it
> > > allows
> > > > > pull
> > > > > > > > requests to be assigned to committers and labelled.
> > > > > > > >
> > > > > > > > I found one discussion link for reference from another Apache
> > > project
> > > > > > > > considering conversion back in July 2017:
> > > > > > > >
> > > > > > > > http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> > > > > > > > Gitbox-td18273.html
> > > > > > > >
> > > > > > > > Please VOTE:
> > > > > > > >
> > > > > > > > [ ] +1 Move to Apache GitBox
> > > > > > > > [ ] +0
> > > > > > > > [ ] -1 Don't move to Apache GitBox because...
> > > > > > > >
> > > > > > > > Voting will end in 72 hours (excluding the weekend), March
> 26,
> > > 2018
> > > > > at
> > > > > > > > 9:00:00 AM EDT
> > > > > > > > https://www.timeanddate.com/countdown/to?iso=20180326T09
> > > > > > > >
> > > > > > > > - Jim King (PMC Member)
> > > > > > > >
> > > > > > >
> > > > >
> > >
>
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by Duru Can Celasun <dc...@apache.org>.
I agree with points 1, 2 and migrating the website to Github.
For 3, if an issue number is required but missing, we should ask the author to amend their commit. But we should also be willing to edit locally if needed. Closing a PR for commit format issues would discourage first time contributors.
For 4, it might be a good idea to have a manually created changelog and require everyone to add a line there for non-trivial changes. This would make the changelog much more readable and flexible, like adding examples if there is a BC break etc.
- Can
On Fri, 6 Apr 2018, at 14:10, James E. King, III wrote:
> Great!
>
> There was a complaint that the CHANGES file has no 0.11.0 data in it from
> the user/dev mailing lists.
> I will open a Jira ticket for that. Let's also make sure it's in the "how
> to release" directions.
>
> I assume that going forward we are going to continue to require Jira
> tickets because that is how
> we generate the CHANGES content. True? Even for simple changes? I would
> like to make it
> earier for the project to accept documentation, website, and build script
> changes without needing
> the heavy weight of a ticket.
>
> Also see https://github.com/apache/thrift/pull/1531 for example. It is a
> very simple bugfix. Now on
> one hand if we don't have a Jira ticket someone cannot search to find the
> "known" issue if they need to.
> On the other hand, our Jira open backlog is tremendously large and folks
> might have trouble finding
> the issue anyway.
>
> So I would like to ask for a discussion about:
>
> 1. No longer requiring the "Client" tag for a check-in.
> 2. No longer needing a Jira thrift ticket for comment-only, doc, website,
> or simple build script changes.
> 3. Now that we can click "rebase and merge" directly on github, but we
> don't have the ability to change
> the commit message, do we simply reject any PR that requires a Jira ticket
> but doesn't have the Jira
> ticket ID in the commit message?
> 4. Do we still want the weight of a Jira ticket for simplistic code
> changes? See this one for an example
> of a simple change. Does it need the full weight of a Jira ticket?
> https://github.com/apache/thrift/pull/1531/
> I suppose if we don't have a Jira ticket we cannot generate CHANGES that
> identify it. Is the CHANGES
> file that useful in its current form?
>
> To these ends I can commit a markdown file that github will display on
> every pull request indicating some
> guidelines people should follow. I will start on one now that follows our
> current rules of requiring a jira ticket
> for everything.
>
> Goal is to get to the point where we can literally have people get their
> PRs right the first time, and get
> the CI build to pass, and then click "Rebase and Merge". (We only want to
> use rebase and merge to
> avoid merge commits). We want it to be easy to submit changes, easy to
> commit the changes, with
> sufficient information to generate release notes.
>
> Finally, can we move the thrift website into github and out of Apache CMS
> somehow?
> This would make it vastly easier to update the website.
>
> - Jim
>
>
> On Fri, Apr 6, 2018 at 7:49 AM, Duru Can Celasun <dc...@apache.org>
> wrote:
>
> > INFRA just added a redirect from git.a.o to Github, which works well for
> > me. I think this solves the immediate problem.
> >
> > On Fri, 6 Apr 2018, at 13:41, James E. King, III wrote:
> > > The INFRA team will not migrate back. We should be able to re-release
> > > package-specific distributions of a given version to resolve.
> > > Or, release 0.12.0 with the correct URLs ASAP. (I like that idea)
> > >
> > > Now it would be nice if I could commit pull requests online rather than
> > > having to do it from the command line, but the commit buttons are not
> > > enabled for me on github.
> > > It looks like I can commit PRs however.
> > >
> > > - Jim
> > >
> > > On Fri, Apr 6, 2018 at 1:19 AM, Duru Can Celasun <dc...@apache.org>
> > > wrote:
> > >
> > > > Per THRIFT-4542, it seems there is no workaround INFRA can do to place
> > a
> > > > mirror or snapshot on git.a.o
> > > >
> > > > For most languages that are effected by this, a single line change in
> > the
> > > > dependency manifest might be enough to fix this (there is a PHP
> > example in
> > > > Jira).
> > > > Unfortunately for us, Go uses the full package path with git.a.o in
> > import
> > > > statements, so there is no easy solution. I'll copy my suggestion from
> > Jira
> > > > below:
> > > >
> > > > - Revert GitBox migration and restore git.a.o
> > > > - Update all URLs (code & docs) to use Github instead of git.a.o
> > > > - Release 0.12 as soon as we can, hopefully sooner rather than later
> > > > - Wait a reasonable amount of time so users have a chance to upgrade
> > > > - Switch to GitBox once again
> > > >
> > > > While this is definitely not ideal, I can't see a viable alternative.
> > > >
> > > > - Can
> > > >
> > > > On Fri, 6 Apr 2018, at 06:39, James E. King, III wrote:
> > > > > Transition to GitBox is complete. The older asf repository is no
> > longer
> > > > > accessible.
> > > > > Removal of the older git repository has broken a number of language
> > > > > packages.
> > > > > Folks are complaining about this and we need to do whatever we can
> > to fix
> > > > > it.
> > > > > This was unexpected as part of the migration.
> > > > >
> > > > > Transition ticket: https://issues.apache.org/jira/browse/INFRA-16287
> > > > >
> > > > > All thrift committers should go to https://gitbox.apache.org/setup/
> > and
> > > > > link your account.
> > > > > Write access is not granted immediately. I don't know how long it
> > takes
> > > > to
> > > > > sync.
> > > > > Hopefully in the morning I will have write access.
> > > > >
> > > > > With this conversion it means our github repository is now the master
> > > > > repository for thrift.
> > > > > Our documentation for developers needs to be updated to reflect this.
> > > > >
> > > > > - Jim
> > > > >
> > > > > On Tue, Apr 3, 2018 at 10:12 AM, Jake Farrell <jf...@apache.org>
> > > > wrote:
> > > > >
> > > > > > result vote never sent for this, closing it out.
> > > > > >
> > > > > > With 6 positive votes (4 binding, 2 non binding), and zero negative
> > > > votes
> > > > > > the vote to move to Apache GitBox for core development passes. I'll
> > > > submit
> > > > > > the request and keep everyone updated as INFRA moves us over
> > > > > >
> > > > > > -Jake
> > > > > >
> > > > > >
> > > > > > Binding positive votes:
> > > > > > Randy Abernethy
> > > > > > Jake Farrell
> > > > > > James King
> > > > > > Aki Sukegawa
> > > > > >
> > > > > > Non Binding positive votes:
> > > > > > Duru Can Celasun
> > > > > > Wang Xin
> > > > > >
> > > > > >
> > > > > > On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <
> > jking@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > > Apache GitBox provides the Thrift project more control over the
> > > > lifecycle
> > > > > > > of pull requests and improve the team's ability to get things
> > done
> > > > in a
> > > > > > > timely manner. The goal is to improve team self-service in
> > GitHub
> > > > and
> > > > > > > integrated CI workflows. One important improvement for
> > committers is
> > > > > > that
> > > > > > > it allows them to "Rebase and Merge" directly in GitHub,
> > assuming the
> > > > > > > commit description meets published guidelines. It also allows
> > for
> > > > more
> > > > > > > control over GitHub features such as issues (note there are no
> > plans
> > > > to
> > > > > > > switch from Apache Hira to GitHub Issues right now), and it
> > allows
> > > > pull
> > > > > > > requests to be assigned to committers and labelled.
> > > > > > >
> > > > > > > I found one discussion link for reference from another Apache
> > project
> > > > > > > considering conversion back in July 2017:
> > > > > > >
> > > > > > > http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> > > > > > > Gitbox-td18273.html
> > > > > > >
> > > > > > > Please VOTE:
> > > > > > >
> > > > > > > [ ] +1 Move to Apache GitBox
> > > > > > > [ ] +0
> > > > > > > [ ] -1 Don't move to Apache GitBox because...
> > > > > > >
> > > > > > > Voting will end in 72 hours (excluding the weekend), March 26,
> > 2018
> > > > at
> > > > > > > 9:00:00 AM EDT
> > > > > > > https://www.timeanddate.com/countdown/to?iso=20180326T09
> > > > > > >
> > > > > > > - Jim King (PMC Member)
> > > > > > >
> > > > > >
> > > >
> >
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by Allen George <al...@gmail.com>.
The only thing to watch out for is that the default message is the
*union* of all individual commit messages, so if you blindly hit
“Squash and Merge” you’ll get an enormous, poorly-formatted commit
message.
I *think* one of my colleagues wrote a chrome plugin that resets the
message textbook to empty, but I’m unsure. I can check up on that.
Allen
On April 6, 2018 at 08:59:10, James E. King, III (jking@apache.org) wrote:
> On Fri, Apr 6, 2018 at 8:47 AM, Allen George wrote:
>
> > Hi Jim,
> >
> > 3. Does “squash and merge” not allow us to change the commit message?
> > We use GitHub at work, and I was always able to change the commit
> > message just before squashing.
> >
> > Best,
> > Allen
> >
> >
> I haven't used "Squash and Merge" before in github. I just tried it on
> that example PR
> and it allowed me to change the title, add the "Client" tag (since we
> require it still)
> and commit to master all from github! It also retained the author
> information.
> I assume this will allow us to deal with unruly commits consisting of
> multiple ids
> as well so we can maintain a clean history. Thanks for the tip!
>
> - Jim
>
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by "James E. King, III" <jk...@apache.org>.
On Fri, Apr 6, 2018 at 8:47 AM, Allen George <al...@gmail.com> wrote:
> Hi Jim,
>
> 3. Does “squash and merge” not allow us to change the commit message?
> We use GitHub at work, and I was always able to change the commit
> message just before squashing.
>
> Best,
> Allen
>
>
I haven't used "Squash and Merge" before in github. I just tried it on
that example PR
and it allowed me to change the title, add the "Client" tag (since we
require it still)
and commit to master all from github! It also retained the author
information.
I assume this will allow us to deal with unruly commits consisting of
multiple ids
as well so we can maintain a clean history. Thanks for the tip!
- Jim
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by Allen George <al...@gmail.com>.
Hi Jim,
1. Totally OK with not requiring a “client” tag on check-in. Since
thrift has a very organized directory structure I could write a script
that takes two commits and spits out something like:
rs:
<sha>: <message>
<sha>: <message>
py:
<sha>: <message>
...
It’s not as nice as a CHANGES file, but at least people could find the
client they’re interested in and see what commits touched it.
2. I agree with skipping JIRAs for comments, docs, website or build
changes. In addition, it would be good to move the thrift website into
github since it lowers the barrier of making changes.
3. Does “squash and merge” not allow us to change the commit message?
We use GitHub at work, and I was always able to change the commit
message just before squashing.
4. This is tough: a lot of people don’t have both GH *and* apache
creds, so it makes it harder for them to submit one-off fixes. Maybe
we should just create the ticket for them and put it in the
description?
Best,
Allen
On April 6, 2018 at 08:10:46, James E. King, III (jking@apache.org) wrote:
> Great!
>
> There was a complaint that the CHANGES file has no 0.11.0 data in it from
> the user/dev mailing lists.
> I will open a Jira ticket for that. Let's also make sure it's in the "how
> to release" directions.
>
> I assume that going forward we are going to continue to require Jira
> tickets because that is how
> we generate the CHANGES content. True? Even for simple changes? I would
> like to make it
> earier for the project to accept documentation, website, and build script
> changes without needing
> the heavy weight of a ticket.
>
> Also see https://github.com/apache/thrift/pull/1531 for example. It is a
> very simple bugfix. Now on
> one hand if we don't have a Jira ticket someone cannot search to find the
> "known" issue if they need to.
> On the other hand, our Jira open backlog is tremendously large and folks
> might have trouble finding
> the issue anyway.
>
> So I would like to ask for a discussion about:
>
> 1. No longer requiring the "Client" tag for a check-in.
> 2. No longer needing a Jira thrift ticket for comment-only, doc, website,
> or simple build script changes.
> 3. Now that we can click "rebase and merge" directly on github, but we
> don't have the ability to change
> the commit message, do we simply reject any PR that requires a Jira ticket
> but doesn't have the Jira
> ticket ID in the commit message?
> 4. Do we still want the weight of a Jira ticket for simplistic code
> changes? See this one for an example
> of a simple change. Does it need the full weight of a Jira ticket?
> https://github.com/apache/thrift/pull/1531/
> I suppose if we don't have a Jira ticket we cannot generate CHANGES that
> identify it. Is the CHANGES
> file that useful in its current form?
>
> To these ends I can commit a markdown file that github will display on
> every pull request indicating some
> guidelines people should follow. I will start on one now that follows our
> current rules of requiring a jira ticket
> for everything.
>
> Goal is to get to the point where we can literally have people get their
> PRs right the first time, and get
> the CI build to pass, and then click "Rebase and Merge". (We only want to
> use rebase and merge to
> avoid merge commits). We want it to be easy to submit changes, easy to
> commit the changes, with
> sufficient information to generate release notes.
>
> Finally, can we move the thrift website into github and out of Apache CMS
> somehow?
> This would make it vastly easier to update the website.
>
> - Jim
>
>
> On Fri, Apr 6, 2018 at 7:49 AM, Duru Can Celasun
> wrote:
>
> > INFRA just added a redirect from git.a.o to Github, which works well for
> > me. I think this solves the immediate problem.
> >
> > On Fri, 6 Apr 2018, at 13:41, James E. King, III wrote:
> > > The INFRA team will not migrate back. We should be able to re-release
> > > package-specific distributions of a given version to resolve.
> > > Or, release 0.12.0 with the correct URLs ASAP. (I like that idea)
> > >
> > > Now it would be nice if I could commit pull requests online rather than
> > > having to do it from the command line, but the commit buttons are not
> > > enabled for me on github.
> > > It looks like I can commit PRs however.
> > >
> > > - Jim
> > >
> > > On Fri, Apr 6, 2018 at 1:19 AM, Duru Can Celasun
> > > wrote:
> > >
> > > > Per THRIFT-4542, it seems there is no workaround INFRA can do to place
> > a
> > > > mirror or snapshot on git.a.o
> > > >
> > > > For most languages that are effected by this, a single line change in
> > the
> > > > dependency manifest might be enough to fix this (there is a PHP
> > example in
> > > > Jira).
> > > > Unfortunately for us, Go uses the full package path with git.a.o in
> > import
> > > > statements, so there is no easy solution. I'll copy my suggestion from
> > Jira
> > > > below:
> > > >
> > > > - Revert GitBox migration and restore git.a.o
> > > > - Update all URLs (code & docs) to use Github instead of git.a.o
> > > > - Release 0.12 as soon as we can, hopefully sooner rather than later
> > > > - Wait a reasonable amount of time so users have a chance to upgrade
> > > > - Switch to GitBox once again
> > > >
> > > > While this is definitely not ideal, I can't see a viable alternative.
> > > >
> > > > - Can
> > > >
> > > > On Fri, 6 Apr 2018, at 06:39, James E. King, III wrote:
> > > > > Transition to GitBox is complete. The older asf repository is no
> > longer
> > > > > accessible.
> > > > > Removal of the older git repository has broken a number of language
> > > > > packages.
> > > > > Folks are complaining about this and we need to do whatever we can
> > to fix
> > > > > it.
> > > > > This was unexpected as part of the migration.
> > > > >
> > > > > Transition ticket: https://issues.apache.org/jira/browse/INFRA-16287
> > > > >
> > > > > All thrift committers should go to https://gitbox.apache.org/setup/
> > and
> > > > > link your account.
> > > > > Write access is not granted immediately. I don't know how long it
> > takes
> > > > to
> > > > > sync.
> > > > > Hopefully in the morning I will have write access.
> > > > >
> > > > > With this conversion it means our github repository is now the master
> > > > > repository for thrift.
> > > > > Our documentation for developers needs to be updated to reflect this.
> > > > >
> > > > > - Jim
> > > > >
> > > > > On Tue, Apr 3, 2018 at 10:12 AM, Jake Farrell
> > > > wrote:
> > > > >
> > > > > > result vote never sent for this, closing it out.
> > > > > >
> > > > > > With 6 positive votes (4 binding, 2 non binding), and zero negative
> > > > votes
> > > > > > the vote to move to Apache GitBox for core development passes. I'll
> > > > submit
> > > > > > the request and keep everyone updated as INFRA moves us over
> > > > > >
> > > > > > -Jake
> > > > > >
> > > > > >
> > > > > > Binding positive votes:
> > > > > > Randy Abernethy
> > > > > > Jake Farrell
> > > > > > James King
> > > > > > Aki Sukegawa
> > > > > >
> > > > > > Non Binding positive votes:
> > > > > > Duru Can Celasun
> > > > > > Wang Xin
> > > > > >
> > > > > >
> > > > > > On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <
> > jking@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > > Apache GitBox provides the Thrift project more control over the
> > > > lifecycle
> > > > > > > of pull requests and improve the team's ability to get things
> > done
> > > > in a
> > > > > > > timely manner. The goal is to improve team self-service in
> > GitHub
> > > > and
> > > > > > > integrated CI workflows. One important improvement for
> > committers is
> > > > > > that
> > > > > > > it allows them to "Rebase and Merge" directly in GitHub,
> > assuming the
> > > > > > > commit description meets published guidelines. It also allows
> > for
> > > > more
> > > > > > > control over GitHub features such as issues (note there are no
> > plans
> > > > to
> > > > > > > switch from Apache Hira to GitHub Issues right now), and it
> > allows
> > > > pull
> > > > > > > requests to be assigned to committers and labelled.
> > > > > > >
> > > > > > > I found one discussion link for reference from another Apache
> > project
> > > > > > > considering conversion back in July 2017:
> > > > > > >
> > > > > > > http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> > > > > > > Gitbox-td18273.html
> > > > > > >
> > > > > > > Please VOTE:
> > > > > > >
> > > > > > > [ ] +1 Move to Apache GitBox
> > > > > > > [ ] +0
> > > > > > > [ ] -1 Don't move to Apache GitBox because...
> > > > > > >
> > > > > > > Voting will end in 72 hours (excluding the weekend), March 26,
> > 2018
> > > > at
> > > > > > > 9:00:00 AM EDT
> > > > > > > https://www.timeanddate.com/countdown/to?iso=20180326T09
> > > > > > >
> > > > > > > - Jim King (PMC Member)
> > > > > > >
> > > > > >
> > > >
> >
>
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by Jens Geyer <je...@hotmail.com>.
website is also out of date.
-----Ursprüngliche Nachricht-----
From: Jens Geyer
Sent: Friday, April 6, 2018 10:20 PM
To: dev@thrift.apache.org
Subject: Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
SHA-1: 327ebb6c2b6df8bf075da02ef45a2a034e9b79ba
-----Ursprüngliche Nachricht-----
From: James E. King, III
Sent: Friday, April 6, 2018 2:10 PM
To: dev@thrift.apache.org
Subject: Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Great!
There was a complaint that the CHANGES file has no 0.11.0 data in it from
the user/dev mailing lists.
I will open a Jira ticket for that. Let's also make sure it's in the "how
to release" directions.
I assume that going forward we are going to continue to require Jira
tickets because that is how
we generate the CHANGES content. True? Even for simple changes? I would
like to make it
earier for the project to accept documentation, website, and build script
changes without needing
the heavy weight of a ticket.
Also see https://github.com/apache/thrift/pull/1531 for example. It is a
very simple bugfix. Now on
one hand if we don't have a Jira ticket someone cannot search to find the
"known" issue if they need to.
On the other hand, our Jira open backlog is tremendously large and folks
might have trouble finding
the issue anyway.
So I would like to ask for a discussion about:
1. No longer requiring the "Client" tag for a check-in.
2. No longer needing a Jira thrift ticket for comment-only, doc, website,
or simple build script changes.
3. Now that we can click "rebase and merge" directly on github, but we
don't have the ability to change
the commit message, do we simply reject any PR that requires a Jira ticket
but doesn't have the Jira
ticket ID in the commit message?
4. Do we still want the weight of a Jira ticket for simplistic code
changes? See this one for an example
of a simple change. Does it need the full weight of a Jira ticket?
https://github.com/apache/thrift/pull/1531/
I suppose if we don't have a Jira ticket we cannot generate CHANGES that
identify it. Is the CHANGES
file that useful in its current form?
To these ends I can commit a markdown file that github will display on
every pull request indicating some
guidelines people should follow. I will start on one now that follows our
current rules of requiring a jira ticket
for everything.
Goal is to get to the point where we can literally have people get their
PRs right the first time, and get
the CI build to pass, and then click "Rebase and Merge". (We only want to
use rebase and merge to
avoid merge commits). We want it to be easy to submit changes, easy to
commit the changes, with
sufficient information to generate release notes.
Finally, can we move the thrift website into github and out of Apache CMS
somehow?
This would make it vastly easier to update the website.
- Jim
On Fri, Apr 6, 2018 at 7:49 AM, Duru Can Celasun <dc...@apache.org>
wrote:
> INFRA just added a redirect from git.a.o to Github, which works well for
> me. I think this solves the immediate problem.
>
> On Fri, 6 Apr 2018, at 13:41, James E. King, III wrote:
> > The INFRA team will not migrate back. We should be able to re-release
> > package-specific distributions of a given version to resolve.
> > Or, release 0.12.0 with the correct URLs ASAP. (I like that idea)
> >
> > Now it would be nice if I could commit pull requests online rather than
> > having to do it from the command line, but the commit buttons are not
> > enabled for me on github.
> > It looks like I can commit PRs however.
> >
> > - Jim
> >
> > On Fri, Apr 6, 2018 at 1:19 AM, Duru Can Celasun <dc...@apache.org>
> > wrote:
> >
> > > Per THRIFT-4542, it seems there is no workaround INFRA can do to place
> a
> > > mirror or snapshot on git.a.o
> > >
> > > For most languages that are effected by this, a single line change in
> the
> > > dependency manifest might be enough to fix this (there is a PHP
> example in
> > > Jira).
> > > Unfortunately for us, Go uses the full package path with git.a.o in
> import
> > > statements, so there is no easy solution. I'll copy my suggestion from
> Jira
> > > below:
> > >
> > > - Revert GitBox migration and restore git.a.o
> > > - Update all URLs (code & docs) to use Github instead of git.a.o
> > > - Release 0.12 as soon as we can, hopefully sooner rather than later
> > > - Wait a reasonable amount of time so users have a chance to upgrade
> > > - Switch to GitBox once again
> > >
> > > While this is definitely not ideal, I can't see a viable alternative.
> > >
> > > - Can
> > >
> > > On Fri, 6 Apr 2018, at 06:39, James E. King, III wrote:
> > > > Transition to GitBox is complete. The older asf repository is no
> longer
> > > > accessible.
> > > > Removal of the older git repository has broken a number of language
> > > > packages.
> > > > Folks are complaining about this and we need to do whatever we can
> to fix
> > > > it.
> > > > This was unexpected as part of the migration.
> > > >
> > > > Transition ticket: https://issues.apache.org/jira/browse/INFRA-16287
> > > >
> > > > All thrift committers should go to https://gitbox.apache.org/setup/
> and
> > > > link your account.
> > > > Write access is not granted immediately. I don't know how long it
> takes
> > > to
> > > > sync.
> > > > Hopefully in the morning I will have write access.
> > > >
> > > > With this conversion it means our github repository is now the
> > > > master
> > > > repository for thrift.
> > > > Our documentation for developers needs to be updated to reflect
> > > > this.
> > > >
> > > > - Jim
> > > >
> > > > On Tue, Apr 3, 2018 at 10:12 AM, Jake Farrell <jf...@apache.org>
> > > wrote:
> > > >
> > > > > result vote never sent for this, closing it out.
> > > > >
> > > > > With 6 positive votes (4 binding, 2 non binding), and zero
> > > > > negative
> > > votes
> > > > > the vote to move to Apache GitBox for core development passes.
> > > > > I'll
> > > submit
> > > > > the request and keep everyone updated as INFRA moves us over
> > > > >
> > > > > -Jake
> > > > >
> > > > >
> > > > > Binding positive votes:
> > > > > Randy Abernethy
> > > > > Jake Farrell
> > > > > James King
> > > > > Aki Sukegawa
> > > > >
> > > > > Non Binding positive votes:
> > > > > Duru Can Celasun
> > > > > Wang Xin
> > > > >
> > > > >
> > > > > On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <
> jking@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Apache GitBox provides the Thrift project more control over the
> > > lifecycle
> > > > > > of pull requests and improve the team's ability to get things
> done
> > > in a
> > > > > > timely manner. The goal is to improve team self-service in
> GitHub
> > > and
> > > > > > integrated CI workflows. One important improvement for
> committers is
> > > > > that
> > > > > > it allows them to "Rebase and Merge" directly in GitHub,
> assuming the
> > > > > > commit description meets published guidelines. It also allows
> for
> > > more
> > > > > > control over GitHub features such as issues (note there are no
> plans
> > > to
> > > > > > switch from Apache Hira to GitHub Issues right now), and it
> allows
> > > pull
> > > > > > requests to be assigned to committers and labelled.
> > > > > >
> > > > > > I found one discussion link for reference from another Apache
> project
> > > > > > considering conversion back in July 2017:
> > > > > >
> > > > > > http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> > > > > > Gitbox-td18273.html
> > > > > >
> > > > > > Please VOTE:
> > > > > >
> > > > > > [ ] +1 Move to Apache GitBox
> > > > > > [ ] +0
> > > > > > [ ] -1 Don't move to Apache GitBox because...
> > > > > >
> > > > > > Voting will end in 72 hours (excluding the weekend), March 26,
> 2018
> > > at
> > > > > > 9:00:00 AM EDT
> > > > > > https://www.timeanddate.com/countdown/to?iso=20180326T09
> > > > > >
> > > > > > - Jim King (PMC Member)
> > > > > >
> > > > >
> > >
>
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by Jens Geyer <je...@hotmail.com>.
SHA-1: 327ebb6c2b6df8bf075da02ef45a2a034e9b79ba
-----Ursprüngliche Nachricht-----
From: James E. King, III
Sent: Friday, April 6, 2018 2:10 PM
To: dev@thrift.apache.org
Subject: Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Great!
There was a complaint that the CHANGES file has no 0.11.0 data in it from
the user/dev mailing lists.
I will open a Jira ticket for that. Let's also make sure it's in the "how
to release" directions.
I assume that going forward we are going to continue to require Jira
tickets because that is how
we generate the CHANGES content. True? Even for simple changes? I would
like to make it
earier for the project to accept documentation, website, and build script
changes without needing
the heavy weight of a ticket.
Also see https://github.com/apache/thrift/pull/1531 for example. It is a
very simple bugfix. Now on
one hand if we don't have a Jira ticket someone cannot search to find the
"known" issue if they need to.
On the other hand, our Jira open backlog is tremendously large and folks
might have trouble finding
the issue anyway.
So I would like to ask for a discussion about:
1. No longer requiring the "Client" tag for a check-in.
2. No longer needing a Jira thrift ticket for comment-only, doc, website,
or simple build script changes.
3. Now that we can click "rebase and merge" directly on github, but we
don't have the ability to change
the commit message, do we simply reject any PR that requires a Jira ticket
but doesn't have the Jira
ticket ID in the commit message?
4. Do we still want the weight of a Jira ticket for simplistic code
changes? See this one for an example
of a simple change. Does it need the full weight of a Jira ticket?
https://github.com/apache/thrift/pull/1531/
I suppose if we don't have a Jira ticket we cannot generate CHANGES that
identify it. Is the CHANGES
file that useful in its current form?
To these ends I can commit a markdown file that github will display on
every pull request indicating some
guidelines people should follow. I will start on one now that follows our
current rules of requiring a jira ticket
for everything.
Goal is to get to the point where we can literally have people get their
PRs right the first time, and get
the CI build to pass, and then click "Rebase and Merge". (We only want to
use rebase and merge to
avoid merge commits). We want it to be easy to submit changes, easy to
commit the changes, with
sufficient information to generate release notes.
Finally, can we move the thrift website into github and out of Apache CMS
somehow?
This would make it vastly easier to update the website.
- Jim
On Fri, Apr 6, 2018 at 7:49 AM, Duru Can Celasun <dc...@apache.org>
wrote:
> INFRA just added a redirect from git.a.o to Github, which works well for
> me. I think this solves the immediate problem.
>
> On Fri, 6 Apr 2018, at 13:41, James E. King, III wrote:
> > The INFRA team will not migrate back. We should be able to re-release
> > package-specific distributions of a given version to resolve.
> > Or, release 0.12.0 with the correct URLs ASAP. (I like that idea)
> >
> > Now it would be nice if I could commit pull requests online rather than
> > having to do it from the command line, but the commit buttons are not
> > enabled for me on github.
> > It looks like I can commit PRs however.
> >
> > - Jim
> >
> > On Fri, Apr 6, 2018 at 1:19 AM, Duru Can Celasun <dc...@apache.org>
> > wrote:
> >
> > > Per THRIFT-4542, it seems there is no workaround INFRA can do to place
> a
> > > mirror or snapshot on git.a.o
> > >
> > > For most languages that are effected by this, a single line change in
> the
> > > dependency manifest might be enough to fix this (there is a PHP
> example in
> > > Jira).
> > > Unfortunately for us, Go uses the full package path with git.a.o in
> import
> > > statements, so there is no easy solution. I'll copy my suggestion from
> Jira
> > > below:
> > >
> > > - Revert GitBox migration and restore git.a.o
> > > - Update all URLs (code & docs) to use Github instead of git.a.o
> > > - Release 0.12 as soon as we can, hopefully sooner rather than later
> > > - Wait a reasonable amount of time so users have a chance to upgrade
> > > - Switch to GitBox once again
> > >
> > > While this is definitely not ideal, I can't see a viable alternative.
> > >
> > > - Can
> > >
> > > On Fri, 6 Apr 2018, at 06:39, James E. King, III wrote:
> > > > Transition to GitBox is complete. The older asf repository is no
> longer
> > > > accessible.
> > > > Removal of the older git repository has broken a number of language
> > > > packages.
> > > > Folks are complaining about this and we need to do whatever we can
> to fix
> > > > it.
> > > > This was unexpected as part of the migration.
> > > >
> > > > Transition ticket: https://issues.apache.org/jira/browse/INFRA-16287
> > > >
> > > > All thrift committers should go to https://gitbox.apache.org/setup/
> and
> > > > link your account.
> > > > Write access is not granted immediately. I don't know how long it
> takes
> > > to
> > > > sync.
> > > > Hopefully in the morning I will have write access.
> > > >
> > > > With this conversion it means our github repository is now the
> > > > master
> > > > repository for thrift.
> > > > Our documentation for developers needs to be updated to reflect
> > > > this.
> > > >
> > > > - Jim
> > > >
> > > > On Tue, Apr 3, 2018 at 10:12 AM, Jake Farrell <jf...@apache.org>
> > > wrote:
> > > >
> > > > > result vote never sent for this, closing it out.
> > > > >
> > > > > With 6 positive votes (4 binding, 2 non binding), and zero
> > > > > negative
> > > votes
> > > > > the vote to move to Apache GitBox for core development passes.
> > > > > I'll
> > > submit
> > > > > the request and keep everyone updated as INFRA moves us over
> > > > >
> > > > > -Jake
> > > > >
> > > > >
> > > > > Binding positive votes:
> > > > > Randy Abernethy
> > > > > Jake Farrell
> > > > > James King
> > > > > Aki Sukegawa
> > > > >
> > > > > Non Binding positive votes:
> > > > > Duru Can Celasun
> > > > > Wang Xin
> > > > >
> > > > >
> > > > > On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <
> jking@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Apache GitBox provides the Thrift project more control over the
> > > lifecycle
> > > > > > of pull requests and improve the team's ability to get things
> done
> > > in a
> > > > > > timely manner. The goal is to improve team self-service in
> GitHub
> > > and
> > > > > > integrated CI workflows. One important improvement for
> committers is
> > > > > that
> > > > > > it allows them to "Rebase and Merge" directly in GitHub,
> assuming the
> > > > > > commit description meets published guidelines. It also allows
> for
> > > more
> > > > > > control over GitHub features such as issues (note there are no
> plans
> > > to
> > > > > > switch from Apache Hira to GitHub Issues right now), and it
> allows
> > > pull
> > > > > > requests to be assigned to committers and labelled.
> > > > > >
> > > > > > I found one discussion link for reference from another Apache
> project
> > > > > > considering conversion back in July 2017:
> > > > > >
> > > > > > http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> > > > > > Gitbox-td18273.html
> > > > > >
> > > > > > Please VOTE:
> > > > > >
> > > > > > [ ] +1 Move to Apache GitBox
> > > > > > [ ] +0
> > > > > > [ ] -1 Don't move to Apache GitBox because...
> > > > > >
> > > > > > Voting will end in 72 hours (excluding the weekend), March 26,
> 2018
> > > at
> > > > > > 9:00:00 AM EDT
> > > > > > https://www.timeanddate.com/countdown/to?iso=20180326T09
> > > > > >
> > > > > > - Jim King (PMC Member)
> > > > > >
> > > > >
> > >
>
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by "James E. King, III" <jk...@apache.org>.
Great!
There was a complaint that the CHANGES file has no 0.11.0 data in it from
the user/dev mailing lists.
I will open a Jira ticket for that. Let's also make sure it's in the "how
to release" directions.
I assume that going forward we are going to continue to require Jira
tickets because that is how
we generate the CHANGES content. True? Even for simple changes? I would
like to make it
earier for the project to accept documentation, website, and build script
changes without needing
the heavy weight of a ticket.
Also see https://github.com/apache/thrift/pull/1531 for example. It is a
very simple bugfix. Now on
one hand if we don't have a Jira ticket someone cannot search to find the
"known" issue if they need to.
On the other hand, our Jira open backlog is tremendously large and folks
might have trouble finding
the issue anyway.
So I would like to ask for a discussion about:
1. No longer requiring the "Client" tag for a check-in.
2. No longer needing a Jira thrift ticket for comment-only, doc, website,
or simple build script changes.
3. Now that we can click "rebase and merge" directly on github, but we
don't have the ability to change
the commit message, do we simply reject any PR that requires a Jira ticket
but doesn't have the Jira
ticket ID in the commit message?
4. Do we still want the weight of a Jira ticket for simplistic code
changes? See this one for an example
of a simple change. Does it need the full weight of a Jira ticket?
https://github.com/apache/thrift/pull/1531/
I suppose if we don't have a Jira ticket we cannot generate CHANGES that
identify it. Is the CHANGES
file that useful in its current form?
To these ends I can commit a markdown file that github will display on
every pull request indicating some
guidelines people should follow. I will start on one now that follows our
current rules of requiring a jira ticket
for everything.
Goal is to get to the point where we can literally have people get their
PRs right the first time, and get
the CI build to pass, and then click "Rebase and Merge". (We only want to
use rebase and merge to
avoid merge commits). We want it to be easy to submit changes, easy to
commit the changes, with
sufficient information to generate release notes.
Finally, can we move the thrift website into github and out of Apache CMS
somehow?
This would make it vastly easier to update the website.
- Jim
On Fri, Apr 6, 2018 at 7:49 AM, Duru Can Celasun <dc...@apache.org>
wrote:
> INFRA just added a redirect from git.a.o to Github, which works well for
> me. I think this solves the immediate problem.
>
> On Fri, 6 Apr 2018, at 13:41, James E. King, III wrote:
> > The INFRA team will not migrate back. We should be able to re-release
> > package-specific distributions of a given version to resolve.
> > Or, release 0.12.0 with the correct URLs ASAP. (I like that idea)
> >
> > Now it would be nice if I could commit pull requests online rather than
> > having to do it from the command line, but the commit buttons are not
> > enabled for me on github.
> > It looks like I can commit PRs however.
> >
> > - Jim
> >
> > On Fri, Apr 6, 2018 at 1:19 AM, Duru Can Celasun <dc...@apache.org>
> > wrote:
> >
> > > Per THRIFT-4542, it seems there is no workaround INFRA can do to place
> a
> > > mirror or snapshot on git.a.o
> > >
> > > For most languages that are effected by this, a single line change in
> the
> > > dependency manifest might be enough to fix this (there is a PHP
> example in
> > > Jira).
> > > Unfortunately for us, Go uses the full package path with git.a.o in
> import
> > > statements, so there is no easy solution. I'll copy my suggestion from
> Jira
> > > below:
> > >
> > > - Revert GitBox migration and restore git.a.o
> > > - Update all URLs (code & docs) to use Github instead of git.a.o
> > > - Release 0.12 as soon as we can, hopefully sooner rather than later
> > > - Wait a reasonable amount of time so users have a chance to upgrade
> > > - Switch to GitBox once again
> > >
> > > While this is definitely not ideal, I can't see a viable alternative.
> > >
> > > - Can
> > >
> > > On Fri, 6 Apr 2018, at 06:39, James E. King, III wrote:
> > > > Transition to GitBox is complete. The older asf repository is no
> longer
> > > > accessible.
> > > > Removal of the older git repository has broken a number of language
> > > > packages.
> > > > Folks are complaining about this and we need to do whatever we can
> to fix
> > > > it.
> > > > This was unexpected as part of the migration.
> > > >
> > > > Transition ticket: https://issues.apache.org/jira/browse/INFRA-16287
> > > >
> > > > All thrift committers should go to https://gitbox.apache.org/setup/
> and
> > > > link your account.
> > > > Write access is not granted immediately. I don't know how long it
> takes
> > > to
> > > > sync.
> > > > Hopefully in the morning I will have write access.
> > > >
> > > > With this conversion it means our github repository is now the master
> > > > repository for thrift.
> > > > Our documentation for developers needs to be updated to reflect this.
> > > >
> > > > - Jim
> > > >
> > > > On Tue, Apr 3, 2018 at 10:12 AM, Jake Farrell <jf...@apache.org>
> > > wrote:
> > > >
> > > > > result vote never sent for this, closing it out.
> > > > >
> > > > > With 6 positive votes (4 binding, 2 non binding), and zero negative
> > > votes
> > > > > the vote to move to Apache GitBox for core development passes. I'll
> > > submit
> > > > > the request and keep everyone updated as INFRA moves us over
> > > > >
> > > > > -Jake
> > > > >
> > > > >
> > > > > Binding positive votes:
> > > > > Randy Abernethy
> > > > > Jake Farrell
> > > > > James King
> > > > > Aki Sukegawa
> > > > >
> > > > > Non Binding positive votes:
> > > > > Duru Can Celasun
> > > > > Wang Xin
> > > > >
> > > > >
> > > > > On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <
> jking@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Apache GitBox provides the Thrift project more control over the
> > > lifecycle
> > > > > > of pull requests and improve the team's ability to get things
> done
> > > in a
> > > > > > timely manner. The goal is to improve team self-service in
> GitHub
> > > and
> > > > > > integrated CI workflows. One important improvement for
> committers is
> > > > > that
> > > > > > it allows them to "Rebase and Merge" directly in GitHub,
> assuming the
> > > > > > commit description meets published guidelines. It also allows
> for
> > > more
> > > > > > control over GitHub features such as issues (note there are no
> plans
> > > to
> > > > > > switch from Apache Hira to GitHub Issues right now), and it
> allows
> > > pull
> > > > > > requests to be assigned to committers and labelled.
> > > > > >
> > > > > > I found one discussion link for reference from another Apache
> project
> > > > > > considering conversion back in July 2017:
> > > > > >
> > > > > > http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> > > > > > Gitbox-td18273.html
> > > > > >
> > > > > > Please VOTE:
> > > > > >
> > > > > > [ ] +1 Move to Apache GitBox
> > > > > > [ ] +0
> > > > > > [ ] -1 Don't move to Apache GitBox because...
> > > > > >
> > > > > > Voting will end in 72 hours (excluding the weekend), March 26,
> 2018
> > > at
> > > > > > 9:00:00 AM EDT
> > > > > > https://www.timeanddate.com/countdown/to?iso=20180326T09
> > > > > >
> > > > > > - Jim King (PMC Member)
> > > > > >
> > > > >
> > >
>
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by Duru Can Celasun <dc...@apache.org>.
INFRA just added a redirect from git.a.o to Github, which works well for me. I think this solves the immediate problem.
On Fri, 6 Apr 2018, at 13:41, James E. King, III wrote:
> The INFRA team will not migrate back. We should be able to re-release
> package-specific distributions of a given version to resolve.
> Or, release 0.12.0 with the correct URLs ASAP. (I like that idea)
>
> Now it would be nice if I could commit pull requests online rather than
> having to do it from the command line, but the commit buttons are not
> enabled for me on github.
> It looks like I can commit PRs however.
>
> - Jim
>
> On Fri, Apr 6, 2018 at 1:19 AM, Duru Can Celasun <dc...@apache.org>
> wrote:
>
> > Per THRIFT-4542, it seems there is no workaround INFRA can do to place a
> > mirror or snapshot on git.a.o
> >
> > For most languages that are effected by this, a single line change in the
> > dependency manifest might be enough to fix this (there is a PHP example in
> > Jira).
> > Unfortunately for us, Go uses the full package path with git.a.o in import
> > statements, so there is no easy solution. I'll copy my suggestion from Jira
> > below:
> >
> > - Revert GitBox migration and restore git.a.o
> > - Update all URLs (code & docs) to use Github instead of git.a.o
> > - Release 0.12 as soon as we can, hopefully sooner rather than later
> > - Wait a reasonable amount of time so users have a chance to upgrade
> > - Switch to GitBox once again
> >
> > While this is definitely not ideal, I can't see a viable alternative.
> >
> > - Can
> >
> > On Fri, 6 Apr 2018, at 06:39, James E. King, III wrote:
> > > Transition to GitBox is complete. The older asf repository is no longer
> > > accessible.
> > > Removal of the older git repository has broken a number of language
> > > packages.
> > > Folks are complaining about this and we need to do whatever we can to fix
> > > it.
> > > This was unexpected as part of the migration.
> > >
> > > Transition ticket: https://issues.apache.org/jira/browse/INFRA-16287
> > >
> > > All thrift committers should go to https://gitbox.apache.org/setup/ and
> > > link your account.
> > > Write access is not granted immediately. I don't know how long it takes
> > to
> > > sync.
> > > Hopefully in the morning I will have write access.
> > >
> > > With this conversion it means our github repository is now the master
> > > repository for thrift.
> > > Our documentation for developers needs to be updated to reflect this.
> > >
> > > - Jim
> > >
> > > On Tue, Apr 3, 2018 at 10:12 AM, Jake Farrell <jf...@apache.org>
> > wrote:
> > >
> > > > result vote never sent for this, closing it out.
> > > >
> > > > With 6 positive votes (4 binding, 2 non binding), and zero negative
> > votes
> > > > the vote to move to Apache GitBox for core development passes. I'll
> > submit
> > > > the request and keep everyone updated as INFRA moves us over
> > > >
> > > > -Jake
> > > >
> > > >
> > > > Binding positive votes:
> > > > Randy Abernethy
> > > > Jake Farrell
> > > > James King
> > > > Aki Sukegawa
> > > >
> > > > Non Binding positive votes:
> > > > Duru Can Celasun
> > > > Wang Xin
> > > >
> > > >
> > > > On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <jk...@apache.org>
> > > > wrote:
> > > >
> > > > > Apache GitBox provides the Thrift project more control over the
> > lifecycle
> > > > > of pull requests and improve the team's ability to get things done
> > in a
> > > > > timely manner. The goal is to improve team self-service in GitHub
> > and
> > > > > integrated CI workflows. One important improvement for committers is
> > > > that
> > > > > it allows them to "Rebase and Merge" directly in GitHub, assuming the
> > > > > commit description meets published guidelines. It also allows for
> > more
> > > > > control over GitHub features such as issues (note there are no plans
> > to
> > > > > switch from Apache Hira to GitHub Issues right now), and it allows
> > pull
> > > > > requests to be assigned to committers and labelled.
> > > > >
> > > > > I found one discussion link for reference from another Apache project
> > > > > considering conversion back in July 2017:
> > > > >
> > > > > http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> > > > > Gitbox-td18273.html
> > > > >
> > > > > Please VOTE:
> > > > >
> > > > > [ ] +1 Move to Apache GitBox
> > > > > [ ] +0
> > > > > [ ] -1 Don't move to Apache GitBox because...
> > > > >
> > > > > Voting will end in 72 hours (excluding the weekend), March 26, 2018
> > at
> > > > > 9:00:00 AM EDT
> > > > > https://www.timeanddate.com/countdown/to?iso=20180326T09
> > > > >
> > > > > - Jim King (PMC Member)
> > > > >
> > > >
> >
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by "James E. King, III" <jk...@apache.org>.
The INFRA team will not migrate back. We should be able to re-release
package-specific distributions of a given version to resolve.
Or, release 0.12.0 with the correct URLs ASAP. (I like that idea)
Now it would be nice if I could commit pull requests online rather than
having to do it from the command line, but the commit buttons are not
enabled for me on github.
It looks like I can commit PRs however.
- Jim
On Fri, Apr 6, 2018 at 1:19 AM, Duru Can Celasun <dc...@apache.org>
wrote:
> Per THRIFT-4542, it seems there is no workaround INFRA can do to place a
> mirror or snapshot on git.a.o
>
> For most languages that are effected by this, a single line change in the
> dependency manifest might be enough to fix this (there is a PHP example in
> Jira).
> Unfortunately for us, Go uses the full package path with git.a.o in import
> statements, so there is no easy solution. I'll copy my suggestion from Jira
> below:
>
> - Revert GitBox migration and restore git.a.o
> - Update all URLs (code & docs) to use Github instead of git.a.o
> - Release 0.12 as soon as we can, hopefully sooner rather than later
> - Wait a reasonable amount of time so users have a chance to upgrade
> - Switch to GitBox once again
>
> While this is definitely not ideal, I can't see a viable alternative.
>
> - Can
>
> On Fri, 6 Apr 2018, at 06:39, James E. King, III wrote:
> > Transition to GitBox is complete. The older asf repository is no longer
> > accessible.
> > Removal of the older git repository has broken a number of language
> > packages.
> > Folks are complaining about this and we need to do whatever we can to fix
> > it.
> > This was unexpected as part of the migration.
> >
> > Transition ticket: https://issues.apache.org/jira/browse/INFRA-16287
> >
> > All thrift committers should go to https://gitbox.apache.org/setup/ and
> > link your account.
> > Write access is not granted immediately. I don't know how long it takes
> to
> > sync.
> > Hopefully in the morning I will have write access.
> >
> > With this conversion it means our github repository is now the master
> > repository for thrift.
> > Our documentation for developers needs to be updated to reflect this.
> >
> > - Jim
> >
> > On Tue, Apr 3, 2018 at 10:12 AM, Jake Farrell <jf...@apache.org>
> wrote:
> >
> > > result vote never sent for this, closing it out.
> > >
> > > With 6 positive votes (4 binding, 2 non binding), and zero negative
> votes
> > > the vote to move to Apache GitBox for core development passes. I'll
> submit
> > > the request and keep everyone updated as INFRA moves us over
> > >
> > > -Jake
> > >
> > >
> > > Binding positive votes:
> > > Randy Abernethy
> > > Jake Farrell
> > > James King
> > > Aki Sukegawa
> > >
> > > Non Binding positive votes:
> > > Duru Can Celasun
> > > Wang Xin
> > >
> > >
> > > On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <jk...@apache.org>
> > > wrote:
> > >
> > > > Apache GitBox provides the Thrift project more control over the
> lifecycle
> > > > of pull requests and improve the team's ability to get things done
> in a
> > > > timely manner. The goal is to improve team self-service in GitHub
> and
> > > > integrated CI workflows. One important improvement for committers is
> > > that
> > > > it allows them to "Rebase and Merge" directly in GitHub, assuming the
> > > > commit description meets published guidelines. It also allows for
> more
> > > > control over GitHub features such as issues (note there are no plans
> to
> > > > switch from Apache Hira to GitHub Issues right now), and it allows
> pull
> > > > requests to be assigned to committers and labelled.
> > > >
> > > > I found one discussion link for reference from another Apache project
> > > > considering conversion back in July 2017:
> > > >
> > > > http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> > > > Gitbox-td18273.html
> > > >
> > > > Please VOTE:
> > > >
> > > > [ ] +1 Move to Apache GitBox
> > > > [ ] +0
> > > > [ ] -1 Don't move to Apache GitBox because...
> > > >
> > > > Voting will end in 72 hours (excluding the weekend), March 26, 2018
> at
> > > > 9:00:00 AM EDT
> > > > https://www.timeanddate.com/countdown/to?iso=20180326T09
> > > >
> > > > - Jim King (PMC Member)
> > > >
> > >
>
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by Duru Can Celasun <dc...@apache.org>.
Per THRIFT-4542, it seems there is no workaround INFRA can do to place a mirror or snapshot on git.a.o
For most languages that are effected by this, a single line change in the dependency manifest might be enough to fix this (there is a PHP example in Jira).
Unfortunately for us, Go uses the full package path with git.a.o in import statements, so there is no easy solution. I'll copy my suggestion from Jira below:
- Revert GitBox migration and restore git.a.o
- Update all URLs (code & docs) to use Github instead of git.a.o
- Release 0.12 as soon as we can, hopefully sooner rather than later
- Wait a reasonable amount of time so users have a chance to upgrade
- Switch to GitBox once again
While this is definitely not ideal, I can't see a viable alternative.
- Can
On Fri, 6 Apr 2018, at 06:39, James E. King, III wrote:
> Transition to GitBox is complete. The older asf repository is no longer
> accessible.
> Removal of the older git repository has broken a number of language
> packages.
> Folks are complaining about this and we need to do whatever we can to fix
> it.
> This was unexpected as part of the migration.
>
> Transition ticket: https://issues.apache.org/jira/browse/INFRA-16287
>
> All thrift committers should go to https://gitbox.apache.org/setup/ and
> link your account.
> Write access is not granted immediately. I don't know how long it takes to
> sync.
> Hopefully in the morning I will have write access.
>
> With this conversion it means our github repository is now the master
> repository for thrift.
> Our documentation for developers needs to be updated to reflect this.
>
> - Jim
>
> On Tue, Apr 3, 2018 at 10:12 AM, Jake Farrell <jf...@apache.org> wrote:
>
> > result vote never sent for this, closing it out.
> >
> > With 6 positive votes (4 binding, 2 non binding), and zero negative votes
> > the vote to move to Apache GitBox for core development passes. I'll submit
> > the request and keep everyone updated as INFRA moves us over
> >
> > -Jake
> >
> >
> > Binding positive votes:
> > Randy Abernethy
> > Jake Farrell
> > James King
> > Aki Sukegawa
> >
> > Non Binding positive votes:
> > Duru Can Celasun
> > Wang Xin
> >
> >
> > On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <jk...@apache.org>
> > wrote:
> >
> > > Apache GitBox provides the Thrift project more control over the lifecycle
> > > of pull requests and improve the team's ability to get things done in a
> > > timely manner. The goal is to improve team self-service in GitHub and
> > > integrated CI workflows. One important improvement for committers is
> > that
> > > it allows them to "Rebase and Merge" directly in GitHub, assuming the
> > > commit description meets published guidelines. It also allows for more
> > > control over GitHub features such as issues (note there are no plans to
> > > switch from Apache Hira to GitHub Issues right now), and it allows pull
> > > requests to be assigned to committers and labelled.
> > >
> > > I found one discussion link for reference from another Apache project
> > > considering conversion back in July 2017:
> > >
> > > http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> > > Gitbox-td18273.html
> > >
> > > Please VOTE:
> > >
> > > [ ] +1 Move to Apache GitBox
> > > [ ] +0
> > > [ ] -1 Don't move to Apache GitBox because...
> > >
> > > Voting will end in 72 hours (excluding the weekend), March 26, 2018 at
> > > 9:00:00 AM EDT
> > > https://www.timeanddate.com/countdown/to?iso=20180326T09
> > >
> > > - Jim King (PMC Member)
> > >
> >
Re: [RESULT][VOTE]: Move from legacy asf git to Apache GitBox
Posted by "James E. King, III" <jk...@apache.org>.
Transition to GitBox is complete. The older asf repository is no longer
accessible.
Removal of the older git repository has broken a number of language
packages.
Folks are complaining about this and we need to do whatever we can to fix
it.
This was unexpected as part of the migration.
Transition ticket: https://issues.apache.org/jira/browse/INFRA-16287
All thrift committers should go to https://gitbox.apache.org/setup/ and
link your account.
Write access is not granted immediately. I don't know how long it takes to
sync.
Hopefully in the morning I will have write access.
With this conversion it means our github repository is now the master
repository for thrift.
Our documentation for developers needs to be updated to reflect this.
- Jim
On Tue, Apr 3, 2018 at 10:12 AM, Jake Farrell <jf...@apache.org> wrote:
> result vote never sent for this, closing it out.
>
> With 6 positive votes (4 binding, 2 non binding), and zero negative votes
> the vote to move to Apache GitBox for core development passes. I'll submit
> the request and keep everyone updated as INFRA moves us over
>
> -Jake
>
>
> Binding positive votes:
> Randy Abernethy
> Jake Farrell
> James King
> Aki Sukegawa
>
> Non Binding positive votes:
> Duru Can Celasun
> Wang Xin
>
>
> On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III <jk...@apache.org>
> wrote:
>
> > Apache GitBox provides the Thrift project more control over the lifecycle
> > of pull requests and improve the team's ability to get things done in a
> > timely manner. The goal is to improve team self-service in GitHub and
> > integrated CI workflows. One important improvement for committers is
> that
> > it allows them to "Rebase and Merge" directly in GitHub, assuming the
> > commit description meets published guidelines. It also allows for more
> > control over GitHub features such as issues (note there are no plans to
> > switch from Apache Hira to GitHub Issues right now), and it allows pull
> > requests to be assigned to committers and labelled.
> >
> > I found one discussion link for reference from another Apache project
> > considering conversion back in July 2017:
> >
> > http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> > Gitbox-td18273.html
> >
> > Please VOTE:
> >
> > [ ] +1 Move to Apache GitBox
> > [ ] +0
> > [ ] -1 Don't move to Apache GitBox because...
> >
> > Voting will end in 72 hours (excluding the weekend), March 26, 2018 at
> > 9:00:00 AM EDT
> > https://www.timeanddate.com/countdown/to?iso=20180326T09
> >
> > - Jim King (PMC Member)
> >
>