You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2025/05/05 13:39:37 UTC
[PR] GH-46318: [Doc][C++] Add Extension Array/Type documents. [arrow]
hiroyuki-sato opened a new pull request, #46319:
URL: https://github.com/apache/arrow/pull/46319
### Rationale for this change
There are no Extension Array/Type documentation in the [API Reference page](https://arrow.apache.org/docs/cpp/api.html).
### What changes are included in this PR?
Add Extension Array / Type API documents.
### Are these changes tested?
No. (Add document only)
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Docs][C++] Add Extension Array/Type documents [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on code in PR #46319:
URL: https://github.com/apache/arrow/pull/46319#discussion_r2074619039
##########
docs/source/cpp/api.rst:
##########
@@ -45,3 +45,4 @@ API Reference
api/flightsql
api/filesystem
api/dataset
+ api/extension
Review Comment:
Thanks! Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Docs][C++] Add Extension Array/Type documents [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46319:
URL: https://github.com/apache/arrow/pull/46319#issuecomment-2853075086
Revision: 7457f6e6a9e613b796b87d7b2f606296b21f9c94
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d84315a140](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d84315a140)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/14850214952/job/41692263649)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Doc][C++] Add Extension Array/Type documents. [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #46319:
URL: https://github.com/apache/arrow/pull/46319#issuecomment-2851222382
[Preview document](http://crossbow.voltrondata.com/pr_docs/46319/cpp/api/extension.html#)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Docs][C++] Add Extension Array/Type documents [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #46319:
URL: https://github.com/apache/arrow/pull/46319#issuecomment-2853071714
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Docs][C++] Add Extension Array/Type documents [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46319:
URL: https://github.com/apache/arrow/pull/46319#discussion_r2074344258
##########
docs/source/cpp/api.rst:
##########
@@ -45,3 +45,4 @@ API Reference
api/flightsql
api/filesystem
api/dataset
+ api/extension
Review Comment:
How about moving this after `datatype` and `array` because this is related to `datatype` and `array`?
```diff
diff --git a/docs/source/cpp/api.rst b/docs/source/cpp/api.rst
index 27b78b57ff..b58a7b7aeb 100644
--- a/docs/source/cpp/api.rst
+++ b/docs/source/cpp/api.rst
@@ -27,6 +27,7 @@ API Reference
api/thread
api/datatype
api/array
+ api/extension
api/scalar
api/builder
api/table
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Docs][C++] Add Extension Array/Type documents [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46319:
URL: https://github.com/apache/arrow/pull/46319#issuecomment-2856187223
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 702de099c8b5aee5c5dbb1306f4fa769cb8f408a.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/41757539635) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Docs][C++] Add Extension Array/Type documents [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #46319:
URL: https://github.com/apache/arrow/pull/46319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Doc][C++] Add Extension Array/Type documents. [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #46319:
URL: https://github.com/apache/arrow/pull/46319#issuecomment-2851076880
I built on the local machine. This is the preview.
<img width="1419" alt="" src="https://github.com/user-attachments/assets/bff338d8-4ac0-43b5-bb6e-3606fbc38c88" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Docs][C++] Add Extension Array/Type documents [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #46319:
URL: https://github.com/apache/arrow/pull/46319#issuecomment-2854663535
@kou Thanks I changed the `extension` location. Please take a look when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Doc][C++] Add Extension Array/Type documents. [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46319:
URL: https://github.com/apache/arrow/pull/46319#issuecomment-2851050211
:warning: GitHub issue #46318 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Doc][C++] Add Extension Array/Type documents. [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #46319:
URL: https://github.com/apache/arrow/pull/46319#issuecomment-2851050709
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46318: [Doc][C++] Add Extension Array/Type documents. [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46319:
URL: https://github.com/apache/arrow/pull/46319#issuecomment-2851056818
Revision: c12f6373fbf55eb2ca582ba08b50241d8ebe6bef
Submitted crossbow builds: [ursacomputing/crossbow @ actions-805dfa8484](https://github.com/ursacomputing/crossbow/branches/all?query=actions-805dfa8484)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/14837883531/job/41653286574)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org