You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/10/14 18:03:28 UTC
[kudu-CR] [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16601
Change subject: [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
......................................................................
[kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
I saw the AdminCliTest.TestUnsafeChangeConfigWithFiveReplicaConfig
scenario failing pre-commit TSAN build [1] with the error like below:
Timed out: Committed consensus opid_index does not equal 1
after waiting for 30.014s. Last opid: 2.2
As I understand, the reason for failing the assertion is an extra
election round that has happened after startup of a tablet. This patch
addresses the issue in the TestUnsafeChangeConfigWithFiveReplicaConfig
and other scenarios which might be affected if same ever happens again.
[1] http://jenkins.kudu.apache.org/job/kudu-gerrit/22585/BUILD_TYPE=TSAN
Change-Id: I1e77c440b872a42c68b6d7d1cb0563fee0470fc2
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 17 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/16601/1
--
To view, visit http://gerrit.cloudera.org:8080/16601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e77c440b872a42c68b6d7d1cb0563fee0470fc2
Gerrit-Change-Number: 16601
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1e77c440b872a42c68b6d7d1cb0563fee0470fc2
Gerrit-Change-Number: 16601
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16601 )
Change subject: [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
......................................................................
[kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
I saw the AdminCliTest.TestUnsafeChangeConfigWithFiveReplicaConfig
scenario failing pre-commit TSAN build [1] with the error like below:
Timed out: Committed consensus opid_index does not equal 1
after waiting for 30.014s. Last opid: 2.2
As I understand, the reason for failing the assertion is an extra
election round that has happened after startup of a tablet. This patch
addresses the issue in the TestUnsafeChangeConfigWithFiveReplicaConfig
and other scenarios which might be affected if same ever happens again.
[1] http://jenkins.kudu.apache.org/job/kudu-gerrit/22585/BUILD_TYPE=TSAN
Change-Id: I1e77c440b872a42c68b6d7d1cb0563fee0470fc2
Reviewed-on: http://gerrit.cloudera.org:8080/16601
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 17 insertions(+), 16 deletions(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e77c440b872a42c68b6d7d1cb0563fee0470fc2
Gerrit-Change-Number: 16601
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16601 )
Change subject: [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
......................................................................
Patch Set 1:
unrelated test failure in ToolTest.TestHmsList
--
To view, visit http://gerrit.cloudera.org:8080/16601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e77c440b872a42c68b6d7d1cb0563fee0470fc2
Gerrit-Change-Number: 16601
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 14 Oct 2020 18:46:02 +0000
Gerrit-HasComments: No
[kudu-CR] [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16601 )
Change subject: [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e77c440b872a42c68b6d7d1cb0563fee0470fc2
Gerrit-Change-Number: 16601
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 14 Oct 2020 18:45:47 +0000
Gerrit-HasComments: No
[kudu-CR] [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16601 )
Change subject: [kudu-admin-test] fix TestUnsafeChangeConfigWithFiveReplicaConfig
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e77c440b872a42c68b6d7d1cb0563fee0470fc2
Gerrit-Change-Number: 16601
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 14 Oct 2020 18:57:30 +0000
Gerrit-HasComments: No