[GitHub] [arrow-julia] ericphanson commented on pull request #464: Formatting

["ericphanson (via GitHub)" <gi...@apache.org>]

ericphanson commented on PR #464:
URL: https://github.com/apache/arrow-julia/pull/464#issuecomment-1589241678

   Something I often do at work is check in a `format` directory with a Project and Manifest, a small `run.jl` script that does the formatting and a readme to explain how. Then the CI job can use the same project/manifest to do the check. This can allow folks to easily run the formatting locally and also ensure that JuliaFormatter updates don’t suddenly cause the CI check to fail on unrelated PRs. (Then if eg a new contributor’s PR fails the format check there is an easy remedy for them - to run the local run script in the format project).
   
   One needs to manually PR the format manifest to update it for newer JuliaFormatter versions but imo that’s worth it being explicit (and you only need to update if there’s some specific change you want).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org