[GitHub] [incubator-dolphinscheduler] normalcc01 opened a new pull request #3727: [Feature][api,dao,sql][backend]add Tag function to ProcessDefinition

[GitBox <gi...@apache.org>]

normalcc01 opened a new pull request #3727:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3727


   ## What is the purpose of the pull request
   
   * This pull request add Tag function to ProcessDefinition. Write the Tag's controller, sercive, mapper code, so that  simple CRUD can be completed independently. And you can add and delete Tags for ProcessDefiniton, and find ProcessDefinitions based on Tag.
   
   ## Brief change log
   
     - create `t_ds_process_definiton_tags` table to store Tag information like `tagname` `project_id` `user_id`. 
        create `t_ds_relation_process_tag` table to store the relationship between Tag and ProcessDefinition.
   
     - add the `Tag` `ProcessTag` classes, the  `controller` `sercive` `mapper` `xml` code for Tag and ProcessTag. In order to realize the verification authority of the `Tag`, the `project_id` `user_id` field is added to `t_ds_process_definiton_tags` table, imitating the similar function code defined in ProcessDefinition.
   
     - `addProcessDefinitionTags` `deleteProcessDefinitionTags` `queryProcessDefinitionByTagId` the three new methods have been added in `ProcessDefinitionService` to realize ProcessDefinition add, delete tags, and query ProcessDefinitions based on tag
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
     - *Added Tag-mapper, sercive, controller tests*
     - *Added ProcessTag-mapper tests.*
     - *Added ProcessDefinition-sercive, controller tests for `testAddProcessDefinitionTags` `testDeleteProcessDefinitionTags` `testQueryProcessDefinitionByTagId`*
   
   ---
   ##拉取请求的目的
   
   *此拉取请求将Tag的功能添加到ProcessDefinition。编写Tag的controller, sercive, mapper代码，以便可以独立完成简单的CRUD。您可以添加和删除ProcessDefiniton的标签，并根据标签查找ProcessDefinitions。
   
   ##简要更改日志
   
     -创建“ t_ds_process_definiton_tags”表以存储标签信息，例如“ tagname”，“ project_id”，“ user_id”。
       创建`t_ds_relation_process_tag`表来存储Tag和ProcessDefinition之间的关系。
   
     -添加`Tag``ProcessTag`类，Tag和ProcessTag的`controller`sercive`mapper`xml`代码。为了实现“Tag”的验证权限，将“ project_id”和“ user_id”字段添加到“ t_ds_process_definiton_tags”表中，这部分模仿ProcessDefinition中的类似的功能代码。
   
     -`addProcessDefinitionTags``deleteProcessDefinitionTags``queryProcessDefinitionByTagId`在`ProcessDefinitionService`中添加了三个新方法，以实现ProcessDefinition添加，删除Tag以及基于Tag查询ProcessDefinition的功能
   
   ##验证此拉取请求
   
   此更改增加了测试，可以进行如下验证：
   
     -*添加了Tag-mapper, sercive, controller层的测试*
     -*添加了ProcessTag-mapper层的测试。*
     -*添加了`testAddProcessDefinitionTags``testDeleteProcessDefinitionTags``testQueryProcessDefinitionByTagId`在ProcessDefinition-sercive, controller层的测试*
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] normalcc01 closed pull request #3727: [Feature][api,dao,sql][backend]add Tag function to ProcessDefinition

[GitBox <gi...@apache.org>]

normalcc01 closed pull request #3727:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3727


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org