You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/14 09:54:47 UTC
[GitHub] [shardingsphere] linghengqian opened a new pull request, #22169: Upgrade dependent versions and fix plugin settings for building GraalVM Native Image
linghengqian opened a new pull request, #22169:
URL: https://github.com/apache/shardingsphere/pull/22169
For #21347.
Changes proposed in this pull request:
- Update native-maven-plugin to bump metadata repo version.
- Upgrade and separate HikariCP version to match native-image metadata in https://github.com/oracle/graalvm-reachability-metadata/tree/master/metadata/com.zaxxer/HikariCP/5.0.1 .
- Upgrade Netty version to use the recommended directory layout for native-image metadata. Refer to https://github.com/netty/netty/issues/12934 .
- Update LICENSE.
- Add Missing OCI tag information of `docker.native` profile.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #22169: Upgrade dependent versions and fix plugin settings for building GraalVM Native Image
Posted by GitBox <gi...@apache.org>.
linghengqian commented on code in PR #22169:
URL: https://github.com/apache/shardingsphere/pull/22169#discussion_r1022363622
##########
infra/common/src/main/java/org/apache/shardingsphere/infra/datasource/pool/metadata/type/hikari/HikariDataSourcePoolMetaData.java:
##########
@@ -51,6 +51,7 @@ private static void buildDefaultProperties() {
DEFAULT_PROPS.put("maximumPoolSize", 50);
DEFAULT_PROPS.put("minimumIdle", 1);
DEFAULT_PROPS.put("readOnly", false);
+ DEFAULT_PROPS.put("keepaliveTime", 0);
Review Comment:
- There doesn't seem to be a direct unit test class for this class. I just added it because HikariCP 4.0.0 added a new property with a default value of 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #22169: Upgrade dependent versions and fix plugin settings for building GraalVM Native Image
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #22169:
URL: https://github.com/apache/shardingsphere/pull/22169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org