[GitHub] [flink] tillrohrmann commented on issue #9703: [FLINK-14038]Add default GC options for flink on yarn to facilitate debugging

[GitBox <gi...@apache.org>]

tillrohrmann commented on issue #9703: [FLINK-14038]Add default GC options for flink on yarn to facilitate debugging
URL: https://github.com/apache/flink/pull/9703#issuecomment-589218431
 
 
   Hi @liupc, sorry for my late response. I was a bit sidetracked due to the last release.
   
   After taking another look at the PR, I actually tend to believe that it would be better to document the JVM options instead of offering special options to activate them. The reasons are the following:
   
   * GC logging is disabled by default anyway. Moreover, different users might need different gc logging settings.
   * Crash on OOM: I think we don't always want to crash on OOMs right away. There are some cases where we can recover (e.g. native memory allocations) and if not, then it is sometimes still possible to send some diagnostics to the `JobManager` and to log a helpful message.
   * Heap dump on OOM: Because there are some acceptable OOMs, we might clutter the local disk with heap dumps if we enable it by default. This might cause a node to fail because of no more disk space.
   
   If you agree with my conclusion, I would suggest to create a new web site under https://ci.apache.org/projects/flink/flink-docs-release-1.10/monitoring which explains how to set the `env.java.opts` instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services