You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/07/15 20:01:04 UTC

Review Request 23511: Await container termination in docker kill test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23511/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Yifan Gu.


Bugs: MESOS-1524
    https://issues.apache.org/jira/browse/MESOS-1524


Repository: mesos-git


Description
-------

Await container termination in Docker kill test so it can be properly reaped before test ends.


Diffs
-----

  src/tests/docker_containerizer_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23511/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 23511: Await container termination in docker kill test

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23511/
-----------------------------------------------------------

(Updated July 17, 2014, 6:59 p.m.)


Review request for mesos, Benjamin Hindman and Yifan Gu.


Bugs: MESOS-1524
    https://issues.apache.org/jira/browse/MESOS-1524


Repository: mesos-git


Description
-------

Await container termination in Docker kill test so it can be properly reaped before test ends.


Diffs
-----

  src/tests/docker_containerizer_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23511/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 23511: Await container termination in docker kill test

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23511/
-----------------------------------------------------------

(Updated July 17, 2014, 6:20 p.m.)


Review request for mesos, Benjamin Hindman and Yifan Gu.


Bugs: MESOS-1524
    https://issues.apache.org/jira/browse/MESOS-1524


Repository: mesos-git


Description
-------

Await container termination in Docker kill test so it can be properly reaped before test ends.


Diffs
-----

  src/tests/docker_containerizer_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23511/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 23511: Await container termination in docker kill test

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23511/#review47885
-----------------------------------------------------------


Bad patch!

Reviews applied: [23511]

Failed command: git apply --index 23511.patch

Error:
 error: src/tests/docker_containerizer_tests.cpp: does not exist in index


- Mesos ReviewBot


On July 15, 2014, 6:01 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23511/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 6:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Yifan Gu.
> 
> 
> Bugs: MESOS-1524
>     https://issues.apache.org/jira/browse/MESOS-1524
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Await container termination in Docker kill test so it can be properly reaped before test ends.
> 
> 
> Diffs
> -----
> 
>   src/tests/docker_containerizer_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23511/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>