[jira] [Commented] (HADOOP-9648) Fix build native library on mac osx

["Arpit Agarwal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687136#comment-13687136 ] 

Arpit Agarwal commented on HADOOP-9648:
---------------------------------------

Thanks for taking this up Kirill. I verified that the native library builds on OSX with your changes.

Few comments from the 2.0.5 patch.

# Tests are not able to load the native library. TestNativeIO fails with "Unable to load native-hadoop library for your platform... using builtin-java classes where applicable".
# The working directory should be restored before returning to avoid changing the callers cwd. I think it would be best to use the mkdirat and openat functions except on OS X via conditional compilation.
{code}
-    if (mkdirat(cwd, token, perm) != 0) {
+    if(fchdir(cwd) < 0) {
{code}
# The iterative approach to replace fcloseall looks somewhat inefficient. At the very least it should be restricted to OS X and fcloseall() used everywhere else.
{code}
+  for (; rl.rlim_max > 2; rl.rlim_max--) {
+    close(rl.rlim_max);
+  }
{code}
# Is this change necessary? I can build without it.
{code}
-        <version>2.4.0a</version>
+        <version>2.5.0</version>
{code}
                
> Fix build native library on mac osx
> -----------------------------------
>
>                 Key: HADOOP-9648
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9648
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.4, 1.2.0, 1.1.2, 2.0.5-alpha
>            Reporter: Kirill A. Korinskiy
>         Attachments: HADOOP-9648-native-osx.1.0.4.patch, HADOOP-9648-native-osx.1.1.2.patch, HADOOP-9648-native-osx.1.2.0.patch, HADOOP-9648-native-osx.2.0.5-alpha-rc1.patch
>
>
> Some patches for fixing build a hadoop native library on os x 10.7/10.8.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira