[jira] [Commented] (HADOOP-11692) Improve authentication failure WARN message to avoid user confusion

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353193#comment-14353193 ] 

Hadoop QA commented on HADOOP-11692:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12703135/HDFS-7857.001.patch
  against trunk revision 5578e22.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ipc.TestRPCWaitForProxy

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5888//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5888//console

This message is automatically generated.

> Improve authentication failure WARN message to avoid user confusion
> -------------------------------------------------------------------
>
>                 Key: HADOOP-11692
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11692
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>              Labels: supportability
>         Attachments: HDFS-7857.001.patch
>
>
> Lots of the following messages appeared in NN log:
> {quote}
> 2014-12-10 12:18:15,728 WARN SecurityLogger.org.apache.hadoop.ipc.Server: Auth failed for <ipAddress>:39838:null (DIGEST-MD5: IO error acquiring password)
> 2014-12-10 12:18:15,728 INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: readAndProcess from client <ipAddress> threw exception [org.apache.hadoop.ipc.StandbyException: Operation category READ is not supported in state standby]
> ......
> SecurityLogger.org.apache.hadoop.ipc.Server: Auth failed for <ipAddress>:39843:null (DIGEST-MD5: IO error acquiring password)
> 2014-12-10 12:18:15,790 INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: readAndProcess from client <ipAddress> threw exception [org.apache.hadoop.ipc.StandbyException: Operation category READ is not supported in state standby]
> {quote}
> The real reason of failure is the second message about StandbyException,
> However, the first message is confusing because it talks about "DIGEST-MD5: IO error acquiring password".
> Filing this jira to modify the first message to have more comprehensive information that can be obtained from {{getCauseForInvalidToken(e)}}.
> {code}
>        try {
>           saslResponse = processSaslMessage(saslMessage);
>         } catch (IOException e) {
>           rpcMetrics.incrAuthenticationFailures();
>           // attempting user could be null
>           AUDITLOG.warn(AUTH_FAILED_FOR + this.toString() + ":"
>               + attemptingUser + " (" + e.getLocalizedMessage() + ")");
>           throw (IOException) getCauseForInvalidToken(e);
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)