[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2790: ARTEMIS-2449 limit size of producer details

[GitBox <gi...@apache.org>]

jbertram commented on a change in pull request #2790: ARTEMIS-2449 limit size of producer details
URL: https://github.com/apache/activemq-artemis/pull/2790#discussion_r312132325
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
 ##########
 @@ -175,7 +176,7 @@
    private final OperationContext context;
 
    // Session's usage should be by definition single threaded, hence it's not needed to use a concurrentHashMap here
-   protected final Map<SimpleString, Pair<Object, AtomicLong>> targetAddressInfos = new HashMap<>();
+   protected final Map<SimpleString, Pair<Object, AtomicLong>> targetAddressInfos = new MaxSizeMap<>(100);
 
 Review comment:
   Yes, it could be configurable and you're right that 100 is arbitrary but so would any other not-ulimited value. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services