You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/12 10:57:53 UTC

[GitHub] [arrow] ovr opened a new pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

ovr opened a new pull request #9175:
URL: https://github.com/apache/arrow/pull/9175


   Rust doesn't provide Eq, Hash for f32/f64 types inside stdlib, it's why I am using an external library called ordered-float which implements this traits. It's better to use external library instead of implementing own inside this repository.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ovr commented on a change in pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
ovr commented on a change in pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#discussion_r556527130



##########
File path: rust/datafusion/tests/sql.rs
##########
@@ -345,6 +345,50 @@ async fn csv_query_group_by_int_min_max() -> Result<()> {
     Ok(())
 }
 
+#[tokio::test]
+async fn csv_query_group_by_float32() -> Result<()> {
+    let mut ctx = ExecutionContext::new();
+    register_aggregate_floats_csv(&mut ctx)?;
+
+    let sql =
+        "SELECT COUNT(*) as cnt, c1 FROM aggregate_floats GROUP BY c1 ORDER BY cnt DESC";
+    let actual = execute(&mut ctx, sql).await;
+
+    // @todo Count OR GROUP BY has a bug?

Review comment:
       @andygrove @alamb @mqy 
   
   Any ideas why COUNT not working with only one value?
   
   Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io edited a comment on pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#issuecomment-758629453


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=h1) Report
   > Merging [#9175](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=desc) (f8da961) into [master](https://codecov.io/gh/apache/arrow/commit/6da7718b47b9d643baa0314981315621fcb619c3?el=desc) (6da7718) will **increase** coverage by `0.02%`.
   > The diff coverage is `85.91%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9175/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9175      +/-   ##
   ==========================================
   + Coverage   81.55%   81.58%   +0.02%     
   ==========================================
     Files         215      215              
     Lines       51600    51716     +116     
   ==========================================
   + Hits        42084    42191     +107     
   - Misses       9516     9525       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/datatypes.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzLnJz) | `78.59% <0.00%> (-0.16%)` | :arrow_down: |
   | [rust/datafusion/src/physical\_plan/hash\_join.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfam9pbi5ycw==) | `84.43% <71.42%> (+0.16%)` | :arrow_up: |
   | [rust/datafusion/src/physical\_plan/group\_scalar.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2dyb3VwX3NjYWxhci5ycw==) | `70.83% <77.77%> (+2.97%)` | :arrow_up: |
   | [...ust/datafusion/src/physical\_plan/hash\_aggregate.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfYWdncmVnYXRlLnJz) | `84.71% <81.81%> (+0.05%)` | :arrow_up: |
   | [rust/datafusion/tests/sql.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3Rlc3RzL3NxbC5ycw==) | `99.83% <100.00%> (+<0.01%)` | :arrow_up: |
   | [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.43% <0.00%> (+0.19%)` | :arrow_up: |
   | [rust/datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zY2FsYXIucnM=) | `57.76% <0.00%> (+0.39%)` | :arrow_up: |
   | [rust/datafusion/src/physical\_plan/common.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvbW1vbi5ycw==) | `78.78% <0.00%> (+13.57%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=footer). Last update [ff1a85a...f8da961](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ovr commented on a change in pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
ovr commented on a change in pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#discussion_r556125440



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -776,6 +785,14 @@ pub(crate) fn create_group_by_values(
     for i in 0..group_by_keys.len() {
         let col = &group_by_keys[i];
         match col.data_type() {
+            DataType::Float32 => {

Review comment:
       I've updated PR, forget about this place. Testing it with real DB example.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] mqy commented on pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#issuecomment-758717943


   No sure but I think it should be OK to use crate `ordered-float`:
   - it has only one  rust file `https://github.com/reem/rust-ordered-float/blob/master/src/lib.rs` of about 800 lines.
   - the crate `num_traits` we are using does not provide `Ord`, `Eq` traits.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ovr commented on a change in pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
ovr commented on a change in pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#discussion_r556526632



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -776,6 +785,14 @@ pub(crate) fn create_group_by_values(
     for i in 0..group_by_keys.len() {
         let col = &group_by_keys[i];
         match col.data_type() {
+            DataType::Float32 => {

Review comment:
       @alamb I've added tests, but I found a strange bug probably with count.
   
   https://github.com/apache/arrow/pull/9175/commits/012c1ac0151878f43d60e3a7090f5b99947e3294#diff-4b06103cf2132b1ab297fbe8cd42622ecbe1109ea26df7d8b358fa36d739549cR357
   
   Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#issuecomment-758629453


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=h1) Report
   > Merging [#9175](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=desc) (f63a13c) into [master](https://codecov.io/gh/apache/arrow/commit/6da7718b47b9d643baa0314981315621fcb619c3?el=desc) (6da7718) will **decrease** coverage by `0.00%`.
   > The diff coverage is `68.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9175/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9175      +/-   ##
   ==========================================
   - Coverage   81.55%   81.55%   -0.01%     
   ==========================================
     Files         215      215              
     Lines       51600    51622      +22     
   ==========================================
   + Hits        42084    42098      +14     
   - Misses       9516     9524       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ust/datafusion/src/physical\_plan/hash\_aggregate.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfYWdncmVnYXRlLnJz) | `83.76% <25.00%> (-0.89%)` | :arrow_down: |
   | [rust/datafusion/src/physical\_plan/group\_scalar.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2dyb3VwX3NjYWxhci5ycw==) | `70.83% <77.77%> (+2.97%)` | :arrow_up: |
   | [rust/arrow/src/datatypes.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzLnJz) | `78.59% <0.00%> (-0.16%)` | :arrow_down: |
   | [rust/datafusion/src/physical\_plan/hash\_join.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfam9pbi5ycw==) | `84.27% <0.00%> (ø)` | |
   | [rust/datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zY2FsYXIucnM=) | `57.76% <0.00%> (+0.39%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=footer). Last update [8e5d09e...f63a13c](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ovr commented on a change in pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
ovr commented on a change in pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#discussion_r556527130



##########
File path: rust/datafusion/tests/sql.rs
##########
@@ -345,6 +345,50 @@ async fn csv_query_group_by_int_min_max() -> Result<()> {
     Ok(())
 }
 
+#[tokio::test]
+async fn csv_query_group_by_float32() -> Result<()> {
+    let mut ctx = ExecutionContext::new();
+    register_aggregate_floats_csv(&mut ctx)?;
+
+    let sql =
+        "SELECT COUNT(*) as cnt, c1 FROM aggregate_floats GROUP BY c1 ORDER BY cnt DESC";
+    let actual = execute(&mut ctx, sql).await;
+
+    // @todo Count OR GROUP BY has a bug?

Review comment:
       @andygrove @alamb @mqy 
   
   Any ideas why COUNT on group not working with only one value?
   
   Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#issuecomment-758578215


   https://issues.apache.org/jira/browse/ARROW-11221


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb closed pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9175:
URL: https://github.com/apache/arrow/pull/9175


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ovr commented on a change in pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
ovr commented on a change in pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#discussion_r556854855



##########
File path: rust/datafusion/tests/sql.rs
##########
@@ -345,6 +345,50 @@ async fn csv_query_group_by_int_min_max() -> Result<()> {
     Ok(())
 }
 
+#[tokio::test]
+async fn csv_query_group_by_float32() -> Result<()> {
+    let mut ctx = ExecutionContext::new();
+    register_aggregate_floats_csv(&mut ctx)?;
+
+    let sql =
+        "SELECT COUNT(*) as cnt, c1 FROM aggregate_floats GROUP BY c1 ORDER BY cnt DESC";
+    let actual = execute(&mut ctx, sql).await;
+
+    // @todo Count OR GROUP BY has a bug?

Review comment:
       Fixed, forget about CSV header...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on a change in pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#discussion_r556163466



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -776,6 +785,14 @@ pub(crate) fn create_group_by_values(
     for i in 0..group_by_keys.len() {
         let col = &group_by_keys[i];
         match col.data_type() {
+            DataType::Float32 => {

Review comment:
       I suggest adding an end-to-end sql test in https://github.com/apache/arrow/blob/master/rust/datafusion/tests/sql.rs to make sure the plumbing is all hooked up correctly




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io edited a comment on pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#issuecomment-758629453


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=h1) Report
   > Merging [#9175](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=desc) (fcb27eb) into [master](https://codecov.io/gh/apache/arrow/commit/6da7718b47b9d643baa0314981315621fcb619c3?el=desc) (6da7718) will **increase** coverage by `0.02%`.
   > The diff coverage is `85.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9175/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9175      +/-   ##
   ==========================================
   + Coverage   81.55%   81.57%   +0.02%     
   ==========================================
     Files         215      215              
     Lines       51600    51714     +114     
   ==========================================
   + Hits        42084    42188     +104     
   - Misses       9516     9526      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/datatypes.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzLnJz) | `78.59% <0.00%> (-0.16%)` | :arrow_down: |
   | [rust/datafusion/src/physical\_plan/hash\_join.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfam9pbi5ycw==) | `84.43% <71.42%> (+0.16%)` | :arrow_up: |
   | [rust/datafusion/src/physical\_plan/group\_scalar.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2dyb3VwX3NjYWxhci5ycw==) | `70.83% <77.77%> (+2.97%)` | :arrow_up: |
   | [...ust/datafusion/src/physical\_plan/hash\_aggregate.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfYWdncmVnYXRlLnJz) | `84.71% <81.81%> (+0.05%)` | :arrow_up: |
   | [rust/datafusion/tests/sql.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3Rlc3RzL3NxbC5ycw==) | `99.83% <100.00%> (+<0.01%)` | :arrow_up: |
   | [rust/datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zY2FsYXIucnM=) | `57.76% <0.00%> (+0.39%)` | :arrow_up: |
   | [rust/datafusion/src/physical\_plan/common.rs](https://codecov.io/gh/apache/arrow/pull/9175/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvbW1vbi5ycw==) | `78.78% <0.00%> (+13.57%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=footer). Last update [ff1a85a...f8da961](https://codecov.io/gh/apache/arrow/pull/9175?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ovr commented on a change in pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

Posted by GitBox <gi...@apache.org>.
ovr commented on a change in pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#discussion_r556125440



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -776,6 +785,14 @@ pub(crate) fn create_group_by_values(
     for i in 0..group_by_keys.len() {
         let col = &group_by_keys[i];
         match col.data_type() {
+            DataType::Float32 => {

Review comment:
       I've updated PR, forget about this place. I am testing it now with real DB example.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org