You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2016/12/12 03:13:34 UTC
Review Request 54643: Added union assignment operator in hashset.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54643/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Vinod Kone.
Repository: mesos
Description
-------
Added union assignment operator in hashset.
Diffs
-----
3rdparty/stout/include/stout/hashset.hpp 8f633cad4d27c1e5f391279b7f3e8cb5fbf4bd03
3rdparty/stout/tests/hashset_tests.cpp eb59d6f1a5fc7b0ba650fefd530b2b4cf82b6c5d
Diff: https://reviews.apache.org/r/54643/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 54643: Added union assignment operator in hashset.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54643/#review158824
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54643]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 12, 2016, 3:13 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54643/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 3:13 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added union assignment operator in hashset.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/hashset.hpp 8f633cad4d27c1e5f391279b7f3e8cb5fbf4bd03
> 3rdparty/stout/tests/hashset_tests.cpp eb59d6f1a5fc7b0ba650fefd530b2b4cf82b6c5d
>
> Diff: https://reviews.apache.org/r/54643/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 54643: Added union assignment operator in hashset.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54643/#review158887
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Dec. 12, 2016, 3:13 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54643/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 3:13 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added union assignment operator in hashset.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/hashset.hpp 8f633cad4d27c1e5f391279b7f3e8cb5fbf4bd03
> 3rdparty/stout/tests/hashset_tests.cpp eb59d6f1a5fc7b0ba650fefd530b2b4cf82b6c5d
>
> Diff: https://reviews.apache.org/r/54643/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>