You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/01 10:38:25 UTC
[GitHub] [pulsar] massakam opened a new pull request #11878: [cli] Fix output format of list of strings by pulsar-admin command
massakam opened a new pull request #11878:
URL: https://github.com/apache/pulsar/pull/11878
### Motivation
In Pulsar version 2.4.2 and earlier, the pulsar-admin command output a list of strings in the following format:
```sh
$ ./bin/pulsar-admin tenants list
public
pulsar
sample
```
On the other hand, in 2.5.0 and later versions, each string is enclosed in double quotes:
```sh
$ ./bin/pulsar-admin tenants list
"public"
"pulsar"
"sample"
```
This is due to https://github.com/apache/pulsar/pull/5313. With this change, strings are now displayed after being encoded to JSON. I don't think these double quotes are needed.
### Modifications
If the type of the variable to be output is `String`, it will be output without JSON encoding.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nkurihar merged pull request #11878: [cli] Fix output format of string by pulsar-admin command
Posted by GitBox <gi...@apache.org>.
nkurihar merged pull request #11878:
URL: https://github.com/apache/pulsar/pull/11878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11878: [cli] Fix output format of string by pulsar-admin command
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11878:
URL: https://github.com/apache/pulsar/pull/11878#issuecomment-927278170
Hi @tuteng Could you please help review this PR from the technical perspective? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org