You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/12 16:20:52 UTC

[GitHub] [spark] zsxwing commented on pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

zsxwing commented on pull request #29729:
URL: https://github.com/apache/spark/pull/29729#issuecomment-726182031


   +1 for adding a flag to address the concerns.
   
   > I think that is the way to go but it's not so simple since strategy classes are API classes. The internal behaviour of them must be subclassed.
   
   I'm not sure how hard it is. Could you give an example?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org