You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2007/09/24 23:38:23 UTC
svn commit: r578987 - in /lucene/hadoop/trunk/src/contrib/hbase: ./
src/java/org/apache/hadoop/hbase/ src/test/org/apache/hadoop/hbase/
Author: stack
Date: Mon Sep 24 14:38:10 2007
New Revision: 578987
URL: http://svn.apache.org/viewvc?rev=578987&view=rev
Log:
HADOOP-1913 Build a Lucene index on an HBase table
Modified:
lucene/hadoop/trunk/src/contrib/hbase/CHANGES.txt
lucene/hadoop/trunk/src/contrib/hbase/src/java/org/apache/hadoop/hbase/HConnectionManager.java
lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/AbstractMergeTestBase.java
lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/MiniHBaseCluster.java
lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestRegionServerAbort.java
lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestTableMapReduce.java
Modified: lucene/hadoop/trunk/src/contrib/hbase/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/contrib/hbase/CHANGES.txt?rev=578987&r1=578986&r2=578987&view=diff
==============================================================================
--- lucene/hadoop/trunk/src/contrib/hbase/CHANGES.txt (original)
+++ lucene/hadoop/trunk/src/contrib/hbase/CHANGES.txt Mon Sep 24 14:38:10 2007
@@ -20,6 +20,8 @@
set of operators, for creating, altering, dropping, inserting,
deleting, and selecting, etc., data in hbase.
(Inchul Song and Edward Yoon via Stack)
+ HADOOP-1913 Build a Lucene index on an HBase table
+ (Ning Li via Stack)
OPTIMIZATIONS
Modified: lucene/hadoop/trunk/src/contrib/hbase/src/java/org/apache/hadoop/hbase/HConnectionManager.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/contrib/hbase/src/java/org/apache/hadoop/hbase/HConnectionManager.java?rev=578987&r1=578986&r2=578987&view=diff
==============================================================================
--- lucene/hadoop/trunk/src/contrib/hbase/src/java/org/apache/hadoop/hbase/HConnectionManager.java (original)
+++ lucene/hadoop/trunk/src/contrib/hbase/src/java/org/apache/hadoop/hbase/HConnectionManager.java Mon Sep 24 14:38:10 2007
@@ -92,7 +92,8 @@
/* encapsulates finding the servers for an HBase instance */
private static class TableServers implements HConnection, HConstants {
- private final Log LOG = LogFactory.getLog(this.getClass().getName());
+ private static final Log LOG = LogFactory.getLog(TableServers.class.
+ getName());
private final Class<? extends HRegionInterface> serverInterfaceClass;
private final long threadWakeFrequency;
private final long pause;
Modified: lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/AbstractMergeTestBase.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/AbstractMergeTestBase.java?rev=578987&r1=578986&r2=578987&view=diff
==============================================================================
--- lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/AbstractMergeTestBase.java (original)
+++ lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/AbstractMergeTestBase.java Mon Sep 24 14:38:10 2007
@@ -27,9 +27,12 @@
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
import org.apache.hadoop.io.Text;
+import org.apache.log4j.Logger;
/** Abstract base class for merge tests */
public abstract class AbstractMergeTestBase extends HBaseTestCase {
+ static final Logger LOG =
+ Logger.getLogger(AbstractMergeTestBase.class.getName());
protected static final Text COLUMN_NAME = new Text("contents:");
protected final Random rand = new Random();
protected HTableDescriptor desc;
@@ -119,8 +122,12 @@
if (dfsCluster != null) {
dfsCluster.shutdown();
}
- if (fs != null) {
- fs.close();
+ if (this.fs != null) {
+ try {
+ this.fs.close();
+ } catch (IOException e) {
+ LOG.info("During tear down got a " + e.getMessage());
+ }
}
}
@@ -151,5 +158,4 @@
region.getRegionInfo().offLine = true;
return region;
}
-
}
Modified: lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/MiniHBaseCluster.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/MiniHBaseCluster.java?rev=578987&r1=578986&r2=578987&view=diff
==============================================================================
--- lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/MiniHBaseCluster.java (original)
+++ lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/MiniHBaseCluster.java Mon Sep 24 14:38:10 2007
@@ -97,7 +97,7 @@
this.conf = conf;
this.fs = dfsCluster.getFileSystem();
- this.cluster = null;
+ this.cluster = dfsCluster;
init(nRegionNodes);
}
@@ -390,7 +390,7 @@
regionServerThreads.size() + " region server(s)");
}
- void shutdown() {
+ public void shutdown() {
MiniHBaseCluster.shutdown(this.masterThread, this.regionThreads);
try {
Modified: lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestRegionServerAbort.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestRegionServerAbort.java?rev=578987&r1=578986&r2=578987&view=diff
==============================================================================
--- lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestRegionServerAbort.java (original)
+++ lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestRegionServerAbort.java Mon Sep 24 14:38:10 2007
@@ -22,6 +22,8 @@
import java.io.IOException;
import java.util.TreeMap;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.io.Text;
import org.apache.log4j.Level;
import org.apache.log4j.Logger;
@@ -30,6 +32,7 @@
* Tests region server failover when a region server exits.
*/
public class TestRegionServerAbort extends HBaseClusterTestCase {
+ private final Log LOG = LogFactory.getLog(this.getClass().getName());
private HTable table;
/** constructor */
@@ -39,7 +42,8 @@
conf.setInt("ipc.client.connect.max.retries", 5); // and number of retries
conf.setInt("hbase.client.retries.number", 5); // reduce HBase retries
Logger.getRootLogger().setLevel(Level.WARN);
- Logger.getLogger(this.getClass().getPackage().getName()).setLevel(Level.DEBUG);
+ Logger.getLogger(this.getClass().getPackage().getName()).
+ setLevel(Level.DEBUG);
}
/**
@@ -68,14 +72,14 @@
this.cluster.startRegionServer();
// Now shutdown the region server and wait for it to go down.
this.cluster.abortRegionServer(0);
- this.cluster.waitOnRegionServer(0);
-
- // Verify that the client can find the data after the region has been moved
- // to a different server
- HScannerInterface scanner =
- table.obtainScanner(HConstants.COLUMN_FAMILY_ARRAY, new Text());
-
+ LOG.info(this.cluster.waitOnRegionServer(0) + " has been shutdown");
+ HScannerInterface scanner = null;
try {
+ // Verify that the client can find the data after the region has moved
+ // to a different server
+ scanner =
+ table.obtainScanner(HConstants.COLUMN_FAMILY_ARRAY, new Text());
+ LOG.info("Obtained scanner " + scanner);
HStoreKey key = new HStoreKey();
TreeMap<Text, byte[]> results = new TreeMap<Text, byte[]>();
while (scanner.next(key, results)) {
@@ -83,11 +87,13 @@
assertEquals(1, results.size());
byte[] bytes = results.get(HConstants.COLUMN_FAMILY);
assertNotNull(bytes);
- assertTrue(tableName.equals(new String(bytes, HConstants.UTF8_ENCODING)));
+ assertTrue(tableName.equals(new String(bytes,
+ HConstants.UTF8_ENCODING)));
}
- System.out.println("Success!");
+ LOG.info("Success!");
} finally {
+ LOG.info("Closing scanner " + scanner);
scanner.close();
}
}
-}
+}
\ No newline at end of file
Modified: lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestTableMapReduce.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestTableMapReduce.java?rev=578987&r1=578986&r2=578987&view=diff
==============================================================================
--- lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestTableMapReduce.java (original)
+++ lucene/hadoop/trunk/src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestTableMapReduce.java Mon Sep 24 14:38:10 2007
@@ -118,7 +118,11 @@
}
if (fs != null) {
- fs.close();
+ try {
+ fs.close();
+ } catch (IOException e) {
+ LOG.info("During tear down got a " + e.getMessage());
+ }
}
}