[GitHub] [netbeans] rtaneja1 commented on a change in pull request #1196: [NETBEANS-2381] JDK 12 ver string support in nbi native win launcher

[GitBox <gi...@apache.org>]

rtaneja1 commented on a change in pull request #1196: [NETBEANS-2381] JDK 12 ver string support in nbi native win launcher
URL: https://github.com/apache/netbeans/pull/1196#discussion_r282424049
 
 

 ##########
 File path: nbi/engine/native/launcher/windows/src/JavaUtils.c
 ##########
 @@ -138,7 +139,7 @@ JavaVersion * getJavaVersionFromString(char * string, DWORD * result) {
             major = (major) * 10 + c - '0';
             if (major > 999) return vers;
             continue;
-        } else if(c=='.'){
+        } else if(c=='.' || c=='+'){
 
 Review comment:
   Without this, method returns null for JDK 12 version string 12+33
   $ java -version
   java version "12" 2019-03-19
   Java(TM) SE Runtime Environment (build 12+33)
   Java HotSpot(TM) 64-Bit Server VM (build 12+33, mixed mode, sharing)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists