You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Steve Niemitz <st...@tellapart.com> on 2015/08/26 19:03:19 UTC
Review Request 37801: Added support for {{mesos.hostname}} in aur
files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Added support for {{mesos.hostname}} in aur files
Diffs
-----
src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
-------
Thanks,
Steve Niemitz
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur
files
Posted by Steve Niemitz <st...@tellapart.com>.
> On Aug. 26, 2015, 5:55 p.m., Zameer Manji wrote:
> > The ticket referenced also talks about {{mesos.ip}}, will you also add support for that?
It's not exposed anywhere by mesos AFAIK. If someone can correct me I can add it in another review.
- Steve
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96565
-----------------------------------------------------------
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37801/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 5:05 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1261
> https://issues.apache.org/jira/browse/AURORA-1261
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added support for {{mesos.hostname}} in aur files
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
> src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
> src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22
> src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b
> src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31
>
> Diff: https://reviews.apache.org/r/37801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve Niemitz
>
>
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur
files
Posted by Stephan Erb <st...@dev.static-void.de>.
> On Aug. 26, 2015, 7:55 p.m., Zameer Manji wrote:
> > The ticket referenced also talks about {{mesos.ip}}, will you also add support for that?
>
> Steve Niemitz wrote:
> It's not exposed anywhere by mesos AFAIK. If someone can correct me I can add it in another review.
I have to agree, looks like Mesos does not export it [1]. I think this review is therefore ready to go. I will update my original ticket to drop the need for ip. We can implement that on our own within the container once the hostname has been exposed.
[1] https://github.com/apache/mesos/blob/8a01dd8d2a6517d2fcf2983a436c5ce37e3666bf/include/mesos/mesos.proto#L848.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96565
-----------------------------------------------------------
On Aug. 28, 2015, 12:48 a.m., Steve Niemitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37801/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2015, 12:48 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1261
> https://issues.apache.org/jira/browse/AURORA-1261
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added support for {{mesos.hostname}} in aur files
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
> src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
> src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22
> src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b
> src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31
>
> Diff: https://reviews.apache.org/r/37801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve Niemitz
>
>
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur
files
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96565
-----------------------------------------------------------
The ticket referenced also talks about {{mesos.ip}}, will you also add support for that?
- Zameer Manji
On Aug. 26, 2015, 10:05 a.m., Steve Niemitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37801/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 10:05 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1261
> https://issues.apache.org/jira/browse/AURORA-1261
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added support for {{mesos.hostname}} in aur files
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
> src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
> src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22
> src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b
> src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31
>
> Diff: https://reviews.apache.org/r/37801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve Niemitz
>
>
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur
files
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96595
-----------------------------------------------------------
Ship it!
Master (1a3ed7f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 26, 2015, 7:37 p.m., Steve Niemitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37801/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 7:37 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1261
> https://issues.apache.org/jira/browse/AURORA-1261
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added support for {{mesos.hostname}} in aur files
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
> src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
> src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22
> src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b
> src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31
>
> Diff: https://reviews.apache.org/r/37801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve Niemitz
>
>
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur
files
Posted by Steve Niemitz <st...@tellapart.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 7:37 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
-------
Added support for {{mesos.hostname}} in aur files
Diffs (updated)
-----
src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
-------
Thanks,
Steve Niemitz
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur
files
Posted by Steve Niemitz <st...@tellapart.com>.
> On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/config/test_thrift.py, line 177
> > <https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177>
> >
> > Would be great to have a non-empty hostname as well to explicitly assert its value.
>
> Steve Niemitz wrote:
> Is there a good way to test this other than something gross like: str(String("{{mesos.hostname}}").bind(*instance.scopes())). Here the hostname is in the binding context but not on any inspectable field on the instance itself.
nm, I figured out a good test here. I'll submit it once I can beat reviewboard into submission.
- Steve
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96560
-----------------------------------------------------------
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37801/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 5:05 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1261
> https://issues.apache.org/jira/browse/AURORA-1261
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added support for {{mesos.hostname}} in aur files
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
> src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
> src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22
> src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b
> src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31
>
> Diff: https://reviews.apache.org/r/37801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve Niemitz
>
>
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur
files
Posted by Steve Niemitz <st...@tellapart.com>.
> On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/config/test_thrift.py, line 177
> > <https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177>
> >
> > Would be great to have a non-empty hostname as well to explicitly assert its value.
Is there a good way to test this other than something gross like: str(String("{{mesos.hostname}}").bind(*instance.scopes())). Here the hostname is in the binding context but not on any inspectable field on the instance itself.
- Steve
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96560
-----------------------------------------------------------
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37801/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 5:05 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1261
> https://issues.apache.org/jira/browse/AURORA-1261
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added support for {{mesos.hostname}} in aur files
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
> src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
> src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22
> src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b
> src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31
>
> Diff: https://reviews.apache.org/r/37801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve Niemitz
>
>
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur
files
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96560
-----------------------------------------------------------
src/test/python/apache/aurora/config/test_thrift.py (line 177)
<https://reviews.apache.org/r/37801/#comment152072>
Would be great to have a non-empty hostname as well to explicitly assert its value.
- Maxim Khutornenko
On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37801/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 5:05 p.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1261
> https://issues.apache.org/jira/browse/AURORA-1261
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added support for {{mesos.hostname}} in aur files
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
> src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
> src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22
> src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b
> src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31
>
> Diff: https://reviews.apache.org/r/37801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve Niemitz
>
>
Re: Review Request 37801: Added support for {{mesos.hostname}} in aur
files
Posted by Steve Niemitz <st...@tellapart.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 5:05 p.m.)
Review request for Aurora.
Bugs: AURORA-1261
https://issues.apache.org/jira/browse/AURORA-1261
Repository: aurora
Description
-------
Added support for {{mesos.hostname}} in aur files
Diffs
-----
src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c
src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558
src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22
src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b
src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31
Diff: https://reviews.apache.org/r/37801/diff/
Testing
-------
Thanks,
Steve Niemitz