You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/02 18:21:00 UTC
[jira] [Commented] (DISPATCH-1231) Edge router fails to sync link
routes due to credit stall
[ https://issues.apache.org/jira/browse/DISPATCH-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732278#comment-16732278 ]
ASF GitHub Bot commented on DISPATCH-1231:
------------------------------------------
codecov-io commented on issue #431: DISPATCH-1231: correct credit handling in core client
URL: https://github.com/apache/qpid-dispatch/pull/431#issuecomment-449682539
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=h1) Report
> Merging [#431](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/4503c7d9bab623c15e3feb73697e06e05fffb45f?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `94.44%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 86.95% 86.98% +0.02%
==========================================
Files 85 85
Lines 18678 18686 +8
==========================================
+ Hits 16242 16254 +12
+ Misses 2436 2432 -4
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==) | `93.61% <100%> (+0.08%)` | :arrow_up: |
| [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85% <100%> (-0.15%)` | :arrow_down: |
| [...core/modules/address\_lookup\_client/lookup\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfY2xpZW50L2xvb2t1cF9jbGllbnQuYw==) | `92.19% <100%> (ø)` | :arrow_up: |
| [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `92.67% <100%> (+0.73%)` | :arrow_up: |
| [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `79.28% <83.33%> (-0.59%)` | :arrow_down: |
| [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `93.33% <0%> (-0.26%)` | :arrow_down: |
| [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.86% <0%> (-0.15%)` | :arrow_down: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.07% <0%> (-0.13%)` | :arrow_down: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.25% <0%> (+0.12%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/qpid-dispatch/pull/431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=footer). Last update [4503c7d...8003d6b](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Edge router fails to sync link routes due to credit stall
> ---------------------------------------------------------
>
> Key: DISPATCH-1231
> URL: https://issues.apache.org/jira/browse/DISPATCH-1231
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Affects Versions: 1.5.0
> Reporter: Ken Giusti
> Priority: Major
>
> core client code erroneously treats credit values as absolute where in fact the values are additive.
> This will result in spurious hangs during the edge router link proxy tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org