You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/07 02:16:52 UTC

[GitHub] [skywalking] arugal commented on a change in pull request #6335: Update the timestamp field type for LogQuery

arugal commented on a change in pull request #6335:
URL: https://github.com/apache/skywalking/pull/6335#discussion_r571517600



##########
File path: test/e2e/e2e-data/src/main/java/org/apache/skywalking/e2e/log/LogMatcher.java
##########
@@ -70,7 +70,7 @@ public void verify(final Log log) {
             doVerify(getTraceId(), log.getTraceId());
         }
         if (nonNull(getTimestamp())) {
-            doVerify(getTimestamp(), log.getTimestamp());
+            doVerify(getTimestamp(), String.valueOf(log.getTimestamp()));

Review comment:
       > Verification doesn't support `long` comparison?
   
   Has supported.
   
   https://github.com/apache/skywalking/blob/fc23dabf37a85cfc27482dbaf25b0109114f6ef7/test/e2e/e2e-data/src/main/java/org/apache/skywalking/e2e/verification/AbstractMatcher.java#L49-L56
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org