You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/15 12:11:13 UTC
[GitHub] [shardingsphere] cherrylzhao opened a new pull request #6051: fix integrate test error in db rule type mode
cherrylzhao opened a new pull request #6051:
URL: https://github.com/apache/shardingsphere/pull/6051
for #5301
- fix select_distinct_with_multi_column_without_order_by
- fix select_distinct_without_order_by
- fix select_with_case_expression
- enable db rule type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 merged pull request #6051: fix integrate test error in db rule type mode
Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #6051:
URL: https://github.com/apache/shardingsphere/pull/6051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #6051: fix integrate test error in db rule type mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6051:
URL: https://github.com/apache/shardingsphere/pull/6051#issuecomment-644127128
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6051?src=pr&el=h1) Report
> Merging [#6051](https://codecov.io/gh/apache/shardingsphere/pull/6051?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b6a858ce5dfc1b41757f6ee3f4a4b7995bc0f689&el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6051/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6051?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6051 +/- ##
============================================
+ Coverage 52.95% 53.13% +0.18%
+ Complexity 439 438 -1
============================================
Files 1195 1188 -7
Lines 20987 20932 -55
Branches 3778 3769 -9
============================================
+ Hits 11113 11122 +9
+ Misses 9177 9112 -65
- Partials 697 698 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6051?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtY29uZmlnY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvY29uZmlnY2VudGVyL0NvbmZpZ0NlbnRlci5qYXZh) | `82.50% <0.00%> (-4.17%)` | `0.00% <0.00%> (ø%)` | |
| [...ere/proxy/frontend/executor/UserExecutorGroup.java](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvZXhlY3V0b3IvVXNlckV4ZWN1dG9yR3JvdXAuamF2YQ==) | `77.77% <0.00%> (-2.23%)` | `0.00% <0.00%> (ø%)` | |
| [...ithm/sharding/CustomDateTimeShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9zdHJhdGVneS9hbGdvcml0aG0vc2hhcmRpbmcvQ3VzdG9tRGF0ZVRpbWVTaGFyZGluZ0FsZ29yaXRobS5qYXZh) | `74.46% <0.00%> (-1.54%)` | `0.00% <0.00%> (ø%)` | |
| [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...sql/parser/binder/metadata/MetaDataConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvTWV0YURhdGFDb25uZWN0aW9uLmphdmE=) | `13.33% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...gsphere/encrypt/algorithm/AESEncryptAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9hbGdvcml0aG0vQUVTRW5jcnlwdEFsZ29yaXRobS5qYXZh) | `80.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...gsphere/encrypt/algorithm/MD5EncryptAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9hbGdvcml0aG0vTUQ1RW5jcnlwdEFsZ29yaXRobS5qYXZh) | `62.50% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...gsphere/encrypt/algorithm/RC4EncryptAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9hbGdvcml0aG0vUkM0RW5jcnlwdEFsZ29yaXRobS5qYXZh) | `94.23% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...sharding/api/config/ShardingRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9hcGkvY29uZmlnL1NoYXJkaW5nUnVsZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arding/strategy/route/ShardingStrategyFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9zdHJhdGVneS9yb3V0ZS9TaGFyZGluZ1N0cmF0ZWd5RmFjdG9yeS5qYXZh) | `42.85% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [84 more](https://codecov.io/gh/apache/shardingsphere/pull/6051/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6051?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6051?src=pr&el=footer). Last update [b6a858c...df9a67b](https://codecov.io/gh/apache/shardingsphere/pull/6051?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org