You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/07 06:57:00 UTC
[jira] [Commented] (FLINK-7099) Replace usages of deprecated
JOB_MANAGER_IPC_PORT_KEY
[ https://issues.apache.org/jira/browse/FLINK-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077706#comment-16077706 ]
ASF GitHub Bot commented on FLINK-7099:
---------------------------------------
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/4278
[FLINK-7099] Replace usages of deprecated JOB_MANAGER_IPC_PORT_KEY and JOB_MANAGER_IPC_ADDRESS_KEY
…d JOB_MANAGER_IPC_ADDRESS_KEY
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-7099
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4278
----
commit 9abf61c22eb88d953082095ec8ea03ef7851f4ac
Author: zjureel <zj...@gmail.com>
Date: 2017-07-07T06:24:31Z
[FLINK-7099] Replace usages of deprecated JOB_MANAGER_IPC_PORT_KEY and JOB_MANAGER_IPC_ADDRESS_KEY
----
> Replace usages of deprecated JOB_MANAGER_IPC_PORT_KEY
> -----------------------------------------------------
>
> Key: FLINK-7099
> URL: https://issues.apache.org/jira/browse/FLINK-7099
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, Local Runtime
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> The deprecated {{ConfigConstants#JOB_MANAGER_IPC_PORT_KEY}} is still used a lot.
> We should replace these usages with {{JobManagerOptions#PORT}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)