You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Carlos Tadeu Panato Junior <no...@github.com> on 2017/08/15 20:48:24 UTC
[jclouds/jclouds] Update field address type to Href and update tests
templates (#1130)
Packet.net change the facilities api response and the address have a Href field now.
this try to fixes the issues we observed when using the jclouds-plugin for jenkins
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1130
-- Commit Summary --
* Update field address type to Href and update tests templates
-- File Changes --
M providers/packet/src/main/java/org/jclouds/packet/domain/Facility.java (5)
M providers/packet/src/test/resources/facilities-first.json (8)
M providers/packet/src/test/resources/facilities-last.json (4)
M providers/packet/src/test/resources/facilities.json (12)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1130.patch
https://github.com/jclouds/jclouds/pull/1130.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Ignasi Barrera <no...@github.com>.
Did you configure the Apache snapshots repo mentioned in Andrea's link? Perhaps the jars were not yet published.This is the build that publishes them and has passed so all should be in place: https://jclouds.ci.cloudbees.com/job/jclouds-labs-2.0.x-branch/
Could you try again?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322871952
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Carlos Tadeu Panato Junior <no...@github.com>.
is it possible release or how can I use that?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322764699
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Carlos Tadeu Panato Junior <no...@github.com>.
working like a charm now :D
thanks @nacx @andreaturli
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322905166
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Andrea Turli <no...@github.com>.
Closed #1130.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#event-1207790833
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Andrea Turli <no...@github.com>.
good question @nacx I'll try to apply it to jclouds-labs 2.0.x as well
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322714368
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Carlos Tadeu Panato Junior <no...@github.com>.
@andreaturli can I build the jcloud-plugin using this commit you did to 2.0.x ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322759653
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Andrea Turli <no...@github.com>.
I think you can build `jclouds-plugin` using that commit or you can use daily builds as described at http://jclouds.apache.org/start/install/. HTH
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322768016
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Andrea Turli <no...@github.com>.
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e153322e)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322691343
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Andrea Turli <no...@github.com>.
merged at [jclouds-labs/2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/e4e8da3a) too
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322719383
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Carlos Tadeu Panato Junior <no...@github.com>.
@nacx yes the jenkins-plugin :) thanks!
I tried to compile but no success to get the jcloud-labs snapshot :/. will try again.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322839891
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Ignasi Barrera <no...@github.com>.
Great! :) And thanks for the patch!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322908107
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Ignasi Barrera <no...@github.com>.
@cpanato do you mean the Jenkins plugin? We don't control it so you'd better talk to them for questions about the next release. They're very kind and release quite often :) If not, having a build from the latest snapshot is pretty straightforward. (/cc @felfert)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322839412
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Ignasi Barrera <no...@github.com>.
Thanks! @andreaturli worth amending and cherry-picking to the 2.0.x branch in the jclouds-labs repo?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322708150
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Carlos Tadeu Panato Junior <no...@github.com>.
ok sorry for the popcorn, was me doing wrong things in mvn :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322895508
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Andrea Turli <no...@github.com>.
thanks @cpanato! Glad to know you guys are using (and fixing) packet.net provider
Please keep up with the great work, merging now!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322687134
Re: [jclouds/jclouds] Update field address type to Href and update
tests templates (#1130)
Posted by Carlos Tadeu Panato Junior <no...@github.com>.
@nacx thanks for the reply. I tried this:
changed the pom.xml in the jclouds-plugin to :
`<jclouds.version>2.1.0-SNAPSHOT</jclouds.version>`
and added:
```
<repository>
<id>jclouds-snapshots</id>
<url>https://repository.apache.org/content/repositories/snapshots</url>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository>
```
when compiling got this error:
```
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/cpanato/project/jcloud/jclouds-plugin/jclouds-plugin/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java:[141,33] no suitable constructor found for Builder(java.lang.String,java.net.URI,java.net.URI,java.util.List<org.jclouds.googlecomputeengine.domain.AttachDisk>)
constructor org.jclouds.googlecomputeengine.domain.NewInstance.Builder.Builder(java.lang.String,java.net.URI,java.net.URI,java.net.URI,java.util.List<org.jclouds.googlecomputeengine.domain.AttachDisk>) is not applicable
(actual and formal argument lists differ in length)
constructor org.jclouds.googlecomputeengine.domain.NewInstance.Builder.Builder(java.lang.String,java.net.URI,java.net.URI,java.net.URI,java.net.URI) is not applicable
(actual and formal argument lists differ in length)
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Jenkins JClouds plugin parent POM .................. SUCCESS [ 8.000 s]
[INFO] jclouds shaded jar for Jenkins plugin .............. SUCCESS [ 10.738 s]
[INFO] Jenkins JClouds plugin ............................. FAILURE [ 17.882 s]
[INFO] ------------------------------------------------------------------------
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322891518