You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by su...@apache.org on 2019/09/25 17:32:41 UTC

[incubator-gobblin] branch master updated: [GOBBLIN-839] Catch all exceptions when getting flow template at runtime

This is an automated email from the ASF dual-hosted git repository.

suvasude pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 8a91dd9  [GOBBLIN-839] Catch all exceptions when getting flow template at runtime
8a91dd9 is described below

commit 8a91dd9a7fca24554e8a9ea351eb7277b2170ff2
Author: Jack Moseley <jm...@linkedin.com>
AuthorDate: Wed Sep 25 10:32:33 2019 -0700

    [GOBBLIN-839] Catch all exceptions when getting flow template at runtime
    
    Closes #2700 from jack-moseley/observer-error-
    handling
---
 .../org/apache/gobblin/service/modules/flowgraph/BaseFlowEdge.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/BaseFlowEdge.java b/gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/BaseFlowEdge.java
index 3d65f6e..78efd1b 100644
--- a/gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/BaseFlowEdge.java
+++ b/gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/BaseFlowEdge.java
@@ -94,9 +94,9 @@ public class BaseFlowEdge implements FlowEdge {
       if (this.flowTemplateCatalog != null) {
         this.flowTemplate = this.flowTemplateCatalog.getFlowTemplate(this.flowTemplate.getUri());
       }
-    } catch (SpecNotFoundException | JobTemplate.TemplateException | IOException | URISyntaxException e) {
+    } catch (Exception e) {
       // If loading template fails, use the template that was successfully loaded on construction
-      log.warn("Failed to get flow template at " + this.flowTemplate.getUri() + ", using in-memory flow template");
+      log.warn("Failed to get flow template " + this.flowTemplate.getUri() + ", using in-memory flow template", e);
     }
     return this.flowTemplate;
   }