You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/09 15:22:29 UTC
[GitHub] [nifi] pgyori opened a new pull request #4814: NIFI-8215: --wait-for-init feature in nifi.sh refactored
pgyori opened a new pull request #4814:
URL: https://github.com/apache/nifi/pull/4814
https://issues.apache.org/jira/browse/NIFI-8215
This makes the --wait-for-init feature in the nifi.sh script runnable in sh on Ubuntu.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee commented on pull request #4814: NIFI-8215: --wait-for-init feature in nifi.sh refactored
Posted by GitBox <gi...@apache.org>.
jfrazee commented on pull request #4814:
URL: https://github.com/apache/nifi/pull/4814#issuecomment-776138163
@pgyori I should have mentioned this since I saw it yesterday, but this doesn't apply the `--wait-for-init` to `restart` since the `$@` isn't provided to the start. The naive change would be this:
```sh
restart)
init
shift
run "stop"
run "start" "$@"
;;
```
I'm not 100% sure whether that's correct though because in `run()` there's some use of `$1` and the `shift` changes `$@`. Should we change this now, or do it later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee commented on pull request #4814: NIFI-8215: --wait-for-init feature in nifi.sh refactored
Posted by GitBox <gi...@apache.org>.
jfrazee commented on pull request #4814:
URL: https://github.com/apache/nifi/pull/4814#issuecomment-776062879
@pgyori I gave this a very quick test on a system using dash as /bin/sh and it works as expected. Reading the code, the changes look correct too. I'm going to do a few other tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pgyori commented on pull request #4814: NIFI-8215: --wait-for-init feature in nifi.sh refactored
Posted by GitBox <gi...@apache.org>.
pgyori commented on pull request #4814:
URL: https://github.com/apache/nifi/pull/4814#issuecomment-776050670
@jfrazee , may I ask you to have a look at this PR?
Thank you in advance!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pgyori commented on pull request #4814: NIFI-8215: --wait-for-init feature in nifi.sh refactored
Posted by GitBox <gi...@apache.org>.
pgyori commented on pull request #4814:
URL: https://github.com/apache/nifi/pull/4814#issuecomment-776152996
@jfrazee I would recommend to postpone this modification until after the release so that we have more time to test it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee edited a comment on pull request #4814: NIFI-8215: --wait-for-init feature in nifi.sh refactored
Posted by GitBox <gi...@apache.org>.
jfrazee edited a comment on pull request #4814:
URL: https://github.com/apache/nifi/pull/4814#issuecomment-776138163
@pgyori I should have mentioned this since I saw it yesterday, but this doesn't apply the `--wait-for-init` to `restart` since the `$@` isn't provided to the `start`. The naive change would be this:
```sh
restart)
init
shift
run "stop"
run "start" "$@"
;;
```
I'm not 100% sure whether that's correct though because in `run()` there's some use of `$1` and the `shift` changes `$@`. Should we change this now, or do it later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pgyori commented on pull request #4814: NIFI-8215: --wait-for-init feature in nifi.sh refactored
Posted by GitBox <gi...@apache.org>.
pgyori commented on pull request #4814:
URL: https://github.com/apache/nifi/pull/4814#issuecomment-776073404
Thank you, @jfrazee !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee closed pull request #4814: NIFI-8215: --wait-for-init feature in nifi.sh refactored
Posted by GitBox <gi...@apache.org>.
jfrazee closed pull request #4814:
URL: https://github.com/apache/nifi/pull/4814
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org