You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrea Turli <no...@github.com> on 2015/05/21 22:19:27 UTC
[jclouds-labs] support docker api v1.18 (#174)
@jbartece could you please review this and test if that fixes https://issues.apache.org/jira/browse/JCLOUDS-900 ?
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/174
-- Commit Summary --
* support docker api v1.18
-- File Changes --
M docker/README.md (8)
M docker/src/main/java/org/jclouds/docker/DockerApiMetadata.java (18)
M docker/src/main/java/org/jclouds/docker/compute/options/DockerTemplateOptions.java (14)
M docker/src/main/java/org/jclouds/docker/domain/HostConfig.java (12)
M docker/src/test/java/org/jclouds/docker/compute/options/DockerTemplateOptionsTest.java (6)
M docker/src/test/java/org/jclouds/docker/features/ContainerApiLiveTest.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/174.patch
https://github.com/jclouds/jclouds-labs/pull/174.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Andrea Turli <no...@github.com>.
I think #221 supercedes this PR. @jbartece can you please look at it and report here, if #174 can be closed? Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-155463815
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Ignasi Barrera <no...@github.com>.
@andreaturli @jbarteceis there something left to be able to merge this PR?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-146320097
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Jakub Bartecek <no...@github.com>.
I ran it and got error, but it is probably caused by the wrong environment. Could you check the logs and tell me what should I change, please? https://gist.github.com/jbartece/4cad0bd49f585a6c004d
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-105501584
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Jakub Bartecek <no...@github.com>.
I rerun the tests and got: https://gist.github.com/jbartece/c7e4f4b993a344726321
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-105532906
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Jakub Bartecek <no...@github.com>.
Is it possible to test it without authentication?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-105509293
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Andrea Turli <no...@github.com>.
@jbartece could you simply run just `ContainerApiLiveTest` and paste the stacktrace of the error on gist, please?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-105497944
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Jakub Bartecek <no...@github.com>.
@andreaturli Hi. I tested it and it doesn't fix the JCLOUDS-900. I think that this bug is not related to the version of Docker API. It looks like it is internal JClouds bug. I found one similar issue: https://issues.apache.org/jira/browse/JCLOUDS-857
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-105493235
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Jakub Bartecek <no...@github.com>.
I really don't have much experience with the security stuff. Do you have any test certificates generated or some HOW-TO manual?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-105509128
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Jakub Bartecek <no...@github.com>.
I found in IRC logs, that it is possible to run the test without authentication using: mvn clean install -Plive -Dtest.docker.identity=root -Dtest.docker.credential=pwd -Dtest.docker.endpoint=http://192.168.59.103:2375
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-105509581
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Andrea Turli <no...@github.com>.
close as #221 fix the same issues and has been already merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-159644092
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Ignasi Barrera <no...@github.com>.
@andreaturli good to rebase & merge?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-149230992
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Jakub Bartecek <no...@github.com>.
@nacx As for me you can merge it
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-146563487
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Andrea Turli <no...@github.com>.
yes it is possible, you filed a bug for that already. Be sure to start your docker engine on `http`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-105510265
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Jakub Bartecek <no...@github.com>.
I'll try to do it on Monday
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#issuecomment-104570550
Re: [jclouds-labs] support docker api v1.18 (#174)
Posted by Andrea Turli <no...@github.com>.
Closed #174.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/174#event-474640206