You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/06/29 19:51:22 UTC
[kudu-CR] Remove unused RunShellCommand() function
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3533
to review the following change.
Change subject: Remove unused RunShellCommand() function
......................................................................
Remove unused RunShellCommand() function
Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2
---
M src/kudu/util/os-util.cc
M src/kudu/util/os-util.h
2 files changed, 0 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/3533/1
--
To view, visit http://gerrit.cloudera.org:8080/3533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Remove unused RunShellProcess() function
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Remove unused RunShellProcess() function
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2100/
--
To view, visit http://gerrit.cloudera.org:8080/3533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Remove unused RunShellProcess() function
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3533
to look at the new patch set (#2).
Change subject: Remove unused RunShellProcess() function
......................................................................
Remove unused RunShellProcess() function
Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2
---
M src/kudu/util/os-util.cc
M src/kudu/util/os-util.h
2 files changed, 0 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/3533/2
--
To view, visit http://gerrit.cloudera.org:8080/3533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Remove unused RunShellCommand() function
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Remove unused RunShellCommand() function
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2097/
--
To view, visit http://gerrit.cloudera.org:8080/3533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Remove unused RunShellProcess() function
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Remove unused RunShellProcess() function
......................................................................
Remove unused RunShellProcess() function
Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2
Reviewed-on: http://gerrit.cloudera.org:8080/3533
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/util/os-util.cc
M src/kudu/util/os-util.h
2 files changed, 0 insertions(+), 33 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Remove unused RunShellProcess() function
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Remove unused RunShellProcess() function
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Remove unused RunShellCommand() function
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Remove unused RunShellCommand() function
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3533/1//COMMIT_MSG
Commit Message:
Line 7: Remove unused RunShellCommand() function
Nit: It's named RunShellProcess()
--
To view, visit http://gerrit.cloudera.org:8080/3533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I881410660a360d2c6f75046dc95d61453b562bd2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes