You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/02/01 02:59:55 UTC

[GitHub] [lucene-solr] rmuir commented on a change in pull request #1141: SOLR-14147 change the Security manager to default to true.

rmuir commented on a change in pull request #1141: SOLR-14147 change the Security manager to default to true.
URL: https://github.com/apache/lucene-solr/pull/1141#discussion_r373753259
 
 

 ##########
 File path: solr/bin/solr.cmd
 ##########
 @@ -1190,12 +1190,11 @@ IF "%ENABLE_REMOTE_JMX_OPTS%"=="true" (
 REM Enable java security manager by default (limiting filesystem access and other things)
 IF NOT DEFINED SOLR_SECURITY_MANAGER_ENABLED (
   set SOLR_SECURITY_MANAGER_ENABLED=true && set SECURITY_MANAGER_OPTS=-Djava.security.manager ^
--Djava.security.policy="%SOLR_SERVER_DIR%\etc\security.policy" ^
--Djava.security.properties="%SOLR_SERVER_DIR%\etc\security.properties" ^
--Dsolr.internal.network.permission=*
+    -Djava.security.policy="%SOLR_SERVER_DIR%\etc\security.policy" ^
+    -Djava.security.properties="%SOLR_SERVER_DIR%\etc\security.properties" ^
+    -Dsolr.internal.network.permission=*
 
 Review comment:
   i think these are just formatting differences, can we nuke them?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org