You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:07:53 UTC
[GitHub] [iceberg] pan3793 opened a new pull request #3058: Exclude zstd-jni from iceberg-spark3-runtime
pan3793 opened a new pull request #3058:
URL: https://github.com/apache/iceberg/pull/3058
`spark-core` already has the dependency `zstd-jni`, it should be exclude from `iceberg-spark3-runtime`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #3058: Build: Exclude zstd-jni from iceberg-spark3-runtime
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #3058:
URL: https://github.com/apache/iceberg/pull/3058#issuecomment-911672952
Confirming what @kbendick said we made this change internally a while back. If everyone else is ok with it I think we should remove the library but this is the kind of change I think we need more folks to check out before we merge just incase we are missing someone's prod usage. @rdblue + @jackye1995 + @openinx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3058: Build: Exclude zstd-jni from iceberg-spark3-runtime
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3058:
URL: https://github.com/apache/iceberg/pull/3058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #3058: Build: Exclude zstd-jni from iceberg-spark3-runtime
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #3058:
URL: https://github.com/apache/iceberg/pull/3058#issuecomment-911466476
cc @RussellSpitzer, please take a look if you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3058: Build: Exclude zstd-jni from iceberg-spark3-runtime
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3058:
URL: https://github.com/apache/iceberg/pull/3058#issuecomment-911835731
Sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #3058: Build: Exclude zstd-jni from iceberg-spark3-runtime
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #3058:
URL: https://github.com/apache/iceberg/pull/3058#issuecomment-914821058
@jackye1995 would u pls take a look as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3058: Build: Exclude zstd-jni from iceberg-spark3-runtime
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3058:
URL: https://github.com/apache/iceberg/pull/3058#issuecomment-916492803
Thanks, @pan3793! I went ahead and merged this since it's been a few days without comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3058: Build: Exclude zstd-jni from iceberg-spark3-runtime
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3058:
URL: https://github.com/apache/iceberg/pull/3058#issuecomment-981916343
I added this to 0.13.0 milestone as it appears it didn't ship with 0.12.1.
I'm not sure if this merits a patch release to 0.12.2... I'd say since we're in progress towards 0.13.0 that it would be easier to hold off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org