You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/12/29 01:19:32 UTC
[GitHub] codecov-io commented on issue #522: SCB-1092 Use a simple time
struct to save memory
codecov-io commented on issue #522: SCB-1092 Use a simple time struct to save memory
URL: https://github.com/apache/servicecomb-service-center/pull/522#issuecomment-450451990
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/522?src=pr&el=h1) Report
> Merging [#522](https://codecov.io/gh/apache/servicecomb-service-center/pull/522?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/72d346cb8de6b12b14793a1b60a13d557f9381ad?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `92.3%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/522?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 59.33% 59.34% +0.01%
==========================================
Files 170 171 +1
Lines 14172 14179 +7
==========================================
+ Hits 8409 8415 +6
Misses 5181 5181
- Partials 582 583 +1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/522?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/core/backend/lease.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/522/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9sZWFzZS5nbw==) | `81.57% <100%> (-0.93%)` | :arrow_down: |
| [pkg/time/time.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/522/diff?src=pr&el=tree#diff-cGtnL3RpbWUvdGltZS5nbw==) | `100% <100%> (ø)` | |
| [pkg/notify/notice.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/522/diff?src=pr&el=tree#diff-cGtnL25vdGlmeS9ub3RpY2UuZ28=) | `80% <50%> (ø)` | :arrow_up: |
| [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/522/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: |
| [server/notify/metrics.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/522/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9tZXRyaWNzLmdv) | `80% <0%> (-10%)` | :arrow_down: |
| [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/522/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: |
| [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/522/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.72% <0%> (-0.19%)` | :arrow_down: |
| [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/522/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: |
| [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/522/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/522/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/522?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/522?src=pr&el=footer). Last update [72d346c...666231a](https://codecov.io/gh/apache/servicecomb-service-center/pull/522?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services