You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "gitgabrio (via GitHub)" <gi...@apache.org> on 2024/02/20 09:16:31 UTC

[I] Analyze and fix `GeneratedFile`constructor [incubator-kie-issues]

gitgabrio opened a new issue, #953:
URL: https://github.com/apache/incubator-kie-issues/issues/953

   See [PR](https://github.com/apache/incubator-kie-drools/pull/5694) 
   Inside the private [GeneratedFile constructor](https://github.com/apache/incubator-kie-drools/blob/72c1d6b184b315554bd24ba4a2f5282f6c57bede/drools-model/drools-codegen-common/src/main/java/org/drools/codegen/common/GeneratedFile.java#L57) there are two parameters related to file position, one as `Path` and one as `String`
   `private GeneratedFile(GeneratedFileType type, Path path, String pathAsString, byte[] contents) {`
   
   The String one is the one originally provided to some public constructor, the `Path` one may be originally provided by calling code or retrieved by the String one.
   
   Scope of this ticket is:
   1. analyze why there is a need for this two separate information `Path path` and `String pathAsString`
   2. consider corner cases, e.g. jars built on one OS and executed on different one
   3. consider usage in downstream projects (e.g. kogito-runtimes)
   4. eventually, remove the `String pathAsString` parameter, if not needed
   5. eventually, hardcode posix translation only when the code is executed inside quarkus (if possible)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org