[jira] [Commented] (BEAM-8021) Add Automatic-Module-Name headers for Beam Java modules

["Preston Koprivica (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-8021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938995#comment-16938995 ] 

Preston Koprivica commented on BEAM-8021:
-----------------------------------------

[~ŁukaszG]I think the PR associated to this issue may have broken local builds.  I'm still very new to beam (and gradle), so please bear with me and apologies if I'm mistaken.  The default for applyJavaNature (as of 2.15.0) was to publish [1].  The project :sdks:java:build-tools was previously being published and there was a compile dependency on it by the flink-runner [2].  It appears that dependency still exists [3], but the build-tools project is no longer being published, hence the broken builds.  

I'm guessing that the reason it wasn't caught in the PR is because the SNAPSHOT artifact was still available in whatever repo the build server was accessing.  And I'm also wondering if this doesn't manifest when you attempt to release it.

[1] https://github.com/apache/beam/blob/v2.15.0/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L129
[2] https://github.com/apache/beam/blob/release-2.15.0/runners/flink/flink_runner.gradle
[3] https://github.com/apache/beam/blob/2acbfbd/runners/flink/flink_runner.gradle#L102

> Add Automatic-Module-Name headers for Beam Java modules 
> --------------------------------------------------------
>
>                 Key: BEAM-8021
>                 URL: https://issues.apache.org/jira/browse/BEAM-8021
>             Project: Beam
>          Issue Type: Sub-task
>          Components: build-system
>            Reporter: Ismaël Mejía
>            Assignee: Lukasz Gajowy
>            Priority: Minor
>             Fix For: 2.17.0
>
>          Time Spent: 8h
>  Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and later, every JAR should have a module name, even if the library does not itself use modules. As [suggested in the mailing list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], this is a simple change that we can do and still be backwards compatible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)