You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:02:03 UTC
[GitHub] [incubator-kvrocks] aleksraiden opened a new pull request, #940: Update jemalloc
aleksraiden opened a new pull request, #940:
URL: https://github.com/apache/incubator-kvrocks/pull/940
Update jemalloc to 5.3.0 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on pull request #940: Update jemalloc
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on PR #940:
URL: https://github.com/apache/incubator-kvrocks/pull/940#issuecomment-1265337159
@tisonkun Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on a diff in pull request #940: Update jemalloc
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on code in PR #940:
URL: https://github.com/apache/incubator-kvrocks/pull/940#discussion_r985673538
##########
cmake/jemalloc.cmake:
##########
@@ -20,8 +20,8 @@ include_guard()
include(cmake/utils.cmake)
FetchContent_DeclareGitHubWithMirror(jemalloc
- jemalloc/jemalloc 12cd13cd418512d9e7596921ccdb62e25a103f87
- MD5=5df60c70718ba94253cb15d60e69e2f8
+ jemalloc/jemalloc refs/tags/5.3.0
Review Comment:
Amm, I'am not sure, that's could be wrong, because jemalloc only tagged new, without release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #940: Update jemalloc
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #940:
URL: https://github.com/apache/incubator-kvrocks/pull/940#discussion_r985654133
##########
cmake/jemalloc.cmake:
##########
@@ -20,8 +20,8 @@ include_guard()
include(cmake/utils.cmake)
FetchContent_DeclareGitHubWithMirror(jemalloc
- jemalloc/jemalloc 12cd13cd418512d9e7596921ccdb62e25a103f87
- MD5=5df60c70718ba94253cb15d60e69e2f8
+ jemalloc/jemalloc refs/tags/5.3.0
Review Comment:
```suggestion
jemalloc/jemalloc 5.3.0
```
IIRC this can be tidy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org