You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2021/07/01 13:44:27 UTC
[GitHub] [wicket] martin-g opened a new pull request #474: Java 9+ module-aware Wicket 9.x
martin-g opened a new pull request #474:
URL: https://github.com/apache/wicket/pull/474
This PR makes Wicket 9.x fully (?!) supporting Java 9+ module system.
I decided to use 9.x instead of 10.x because this way it will be easier to test it with our production applications.
If there is a stopper then we will apply these changes only to 10.x. But the module-aware Wicket is backward compatible then we could merge it for 9.5.0.
At the moment the only issue I am aware of is with clirr-maven-plugin:
```
[ERROR] Failed to execute goal org.codehaus.mojo:clirr-maven-plugin:2.8:check (clirr-check) on project wicket-util: Execution clirr-check of goal org.codehaus.mojo:clirr-maven-plugin:2.8:check failed: Invalid byte tag in constant pool: 19 -> [Help 1]
```
So you need to build with `mvn ... -Dclirr.skip=true`
I will contact Clirr project to see whether a new version could be released.
Another (smaller) issue is that few dependencies do not provide proper Java modules (e.g. javax.servlet-api, cglib, velocty, commons-fileupload, ...). I am not sure whether this is a deal-breaker or not.
I'll be thankful if you could test this branch and report issues!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #474:
URL: https://github.com/apache/wicket/pull/474#issuecomment-873130716
Not really a cleanup.
I needed to move some test classes to unique packages.
We have a test for this in testing/common-testts but it covers just the
main sources.
JPMS complained that some packages are in more than one modules.
So I moved **.util.* to **.core.util.*
On Fri, Jul 2, 2021, 18:39 Andrea Del Bene ***@***.***> wrote:
> I see you did also some code clean-up (for util classes for example). Good!
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/wicket/pull/474#issuecomment-873088551>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABYUQT65DYEFQOXB3B6BLTTVXMSRANCNFSM47UYGJIQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r663816604
##########
File path: pom.xml
##########
@@ -142,6 +142,7 @@
<commons-collections.version>3.2.2</commons-collections.version>
<commons-collections4.version>4.4</commons-collections4.version>
<commons-fileupload.version>1.4</commons-fileupload.version>
+<!-- <commons-fileupload.version>0.68.0.1</commons-fileupload.version>-->
Review comment:
Done!
##########
File path: pom.xml
##########
@@ -169,7 +170,7 @@
<mockito.version>3.11.1</mockito.version>
<objenesis.version>3.2</objenesis.version>
<openjson.version>1.0.12</openjson.version>
- <slf4j.version>1.7.25</slf4j.version>
+ <slf4j.version>2.0.0-alpha1</slf4j.version>
Review comment:
Because SLF4J added support for JPMS in 2.x.
They just released alpha2.
Hopefully they will release 2.0.0 soon! But SLF4J project is not very active lately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #474:
URL: https://github.com/apache/wicket/pull/474#issuecomment-881433068
I've tested this branch in a real application both with Tomcat 9.0.50 and Jetty 10.0.6.
I didn't find any issue with the application related to JPMS.
My only concern before merging the branch to `wicket-9.x` is the usage of slf4j 2.0.0-alpha2. This might scare some people.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r663817735
##########
File path: pom.xml
##########
@@ -169,7 +170,7 @@
<mockito.version>3.11.1</mockito.version>
<objenesis.version>3.2</objenesis.version>
<openjson.version>1.0.12</openjson.version>
- <slf4j.version>1.7.25</slf4j.version>
+ <slf4j.version>2.0.0-alpha1</slf4j.version>
Review comment:
Because SLF4J added support for JPMS in 2.x.
They just released alpha2.
Hopefully they will release 2.0.0 soon! But SLF4J project is not very active lately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] solomax commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r664354043
##########
File path: pom.xml
##########
@@ -169,7 +170,7 @@
<mockito.version>3.11.1</mockito.version>
<objenesis.version>3.2</objenesis.version>
<openjson.version>1.0.12</openjson.version>
- <slf4j.version>1.7.25</slf4j.version>
+ <slf4j.version>2.0.0-alpha1</slf4j.version>
Review comment:
they had alphas and betas only for very long time :(
let's see :))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g merged pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #474:
URL: https://github.com/apache/wicket/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r663816604
##########
File path: pom.xml
##########
@@ -142,6 +142,7 @@
<commons-collections.version>3.2.2</commons-collections.version>
<commons-collections4.version>4.4</commons-collections4.version>
<commons-fileupload.version>1.4</commons-fileupload.version>
+<!-- <commons-fileupload.version>0.68.0.1</commons-fileupload.version>-->
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] bitstorm commented on pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
bitstorm commented on pull request #474:
URL: https://github.com/apache/wicket/pull/474#issuecomment-873088551
I see you did also some code clean-up (for util classes for example). Good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #474:
URL: https://github.com/apache/wicket/pull/474#issuecomment-872261034
// CC @jonathanlocke @svenmeier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #474:
URL: https://github.com/apache/wicket/pull/474#issuecomment-872263147
TODO JPMS-fy the http2 modules. I decided to do it in separate commit so that it is easier to cherry-pick in 10.x where those were merged to -core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] solomax commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r664354043
##########
File path: pom.xml
##########
@@ -169,7 +170,7 @@
<mockito.version>3.11.1</mockito.version>
<objenesis.version>3.2</objenesis.version>
<openjson.version>1.0.12</openjson.version>
- <slf4j.version>1.7.25</slf4j.version>
+ <slf4j.version>2.0.0-alpha1</slf4j.version>
Review comment:
they had alphas and betas only for very long time :(
let's see :))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] solomax commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r663311532
##########
File path: pom.xml
##########
@@ -142,6 +142,7 @@
<commons-collections.version>3.2.2</commons-collections.version>
<commons-collections4.version>4.4</commons-collections4.version>
<commons-fileupload.version>1.4</commons-fileupload.version>
+<!-- <commons-fileupload.version>0.68.0.1</commons-fileupload.version>-->
Review comment:
I guess this one can be removed
##########
File path: pom.xml
##########
@@ -169,7 +170,7 @@
<mockito.version>3.11.1</mockito.version>
<objenesis.version>3.2</objenesis.version>
<openjson.version>1.0.12</openjson.version>
- <slf4j.version>1.7.25</slf4j.version>
+ <slf4j.version>2.0.0-alpha1</slf4j.version>
Review comment:
Why to update to `alpha`?
##########
File path: pom.xml
##########
@@ -290,6 +290,7 @@
<version>${commons-fileupload.version}</version>
<exclusions>
<exclusion>
+<!-- <groupId>com.jwebmp.jpms.commons</groupId>-->
Review comment:
I guess this one can be dropped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org