[GitHub] [airflow] ashb commented on a change in pull request #7251: [AIRFLOW-6628] Fix search auto complete behaviour

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #7251: [AIRFLOW-6628] Fix search auto complete behaviour
URL: https://github.com/apache/airflow/pull/7251#discussion_r373688156
 
 

 ##########
 File path: airflow/www/views.py
 ##########
 @@ -325,10 +319,36 @@ def get_int_arg(value, default=0):
             paging=wwwutils.generate_pages(current_page, num_of_pages,
                                            search=escape(arg_search_query) if arg_search_query else None,
                                            showPaused=not hide_paused),
-            auto_complete_data=auto_complete_data,
             num_runs=num_runs,
             tags=tags)
 
+    @expose('/dag_autocomplete')
+    @has_access
 
 Review comment:
   For the record: I am not a fan of each view being a new permission; instead I am of the view that permissions should be about operations/concepts - so can list, can get details etc -> I can see no reason why you might want to view details/list a dag but not have it show up in the auto complete list for instance
   
   (Not saying change this now, but if we re-think the permissions for the API work)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services