You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/10 14:55:10 UTC

[GitHub] [arrow-datafusion] waynexia opened a new pull request, #2717: Fix clippy warnings with toolchain 1.63

waynexia opened a new pull request, #2717:
URL: https://github.com/apache/arrow-datafusion/pull/2717

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   I got these clippy lints after updating my rust toolchain to 1.63.
   
   Most warnings come from these rules:
   
   https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
   https://rust-lang.github.io/rust-clippy/master/index.html#format_push_string
   https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
   https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
   
   I'm not sure whether the second rule `format_push_string` is acceptable so I split it into another commit.
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Fix clippy warnings.
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold commented on pull request #2717: Fix clippy warnings with toolchain 1.63

Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2717:
URL: https://github.com/apache/arrow-datafusion/pull/2717#issuecomment-1152553589

   > I'm not sure whether the second rule format_push_string is acceptable so I split it into another commit.
   
   It's fine by me, writing to a string is infallible and so there is nothing to do with the errors


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold merged pull request #2717: Fix clippy warnings with toolchain 1.63

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2717:
URL: https://github.com/apache/arrow-datafusion/pull/2717


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org