You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/02/20 13:32:02 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

eladkal commented on code in PR #28953:
URL: https://github.com/apache/airflow/pull/28953#discussion_r1111964786


##########
airflow/providers/telegram/CHANGELOG.rst:
##########
@@ -24,6 +24,23 @@
 Changelog
 ---------
 
+3.2.0
+.....

Review Comment:
   ```suggestion
   4.0.0
   .....
   
   Breaking changes
   ~~~~~~~~~~~~~~~~
   ```



##########
airflow/providers/telegram/CHANGELOG.rst:
##########
@@ -24,6 +24,23 @@
 Changelog
 ---------
 
+3.2.0
+.....
+
+In this version, we upgraded the ``python-telegram-bot`` to ``20.0.0`` and above.
+All remains the same except that now the ``get_conn()`` method in ``TelegramHook`` is a coroutine function.
+Refer to `python-telegram-bot transition guide <https://github.com/python-telegram-bot/python-telegram-bot/wiki/Transition-guide-to-Version-20.0#asyncio>`_ for more details.
+
+Misc
+~~~~
+
+* ``Upgraded python-telegram-bot to 20.0.0 and above``
+* ``Updated unit tests to handle coroutine functions``
+
+.. Below changes are excluded from the changelog. Move them to
+   appropriate section above if needed. Do not delete the lines(!):

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org