You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by GitBox <gi...@apache.org> on 2021/10/02 14:42:12 UTC
[GitHub] [ant] arturobernalg opened a new pull request #162: Use Bulk operation instead of iteration.
arturobernalg opened a new pull request #162:
URL: https://github.com/apache/ant/pull/162
Some operations inside loops that could be replaced with a bulk method. Bulk methods are shorter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] arturobernalg commented on pull request #162: Use Bulk operation instead of iteration.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #162:
URL: https://github.com/apache/ant/pull/162#issuecomment-932936163
> thank you @arturobernalg Currently there is a release vote underway and I don't want to disturb things by changing `master` before it is done.
Completely agree. This is a minor change. can wait.
Thank you @bodewig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig merged pull request #162: Use Bulk operation instead of iteration.
Posted by GitBox <gi...@apache.org>.
bodewig merged pull request #162:
URL: https://github.com/apache/ant/pull/162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] arturobernalg commented on a change in pull request #162: Use Bulk operation instead of iteration.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #162:
URL: https://github.com/apache/ant/pull/162#discussion_r720815321
##########
File path: src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java
##########
@@ -294,7 +294,7 @@ public void send() {
? new InternetAddress(addr.getAddress())
: new InternetAddress(addr.getAddress(), name));
}
- return addrs.toArray(new InternetAddress[addrs.size()]);
+ return addrs.toArray(new InternetAddress[0]);
Review comment:
Hi @bodewig
Reverted.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on a change in pull request #162: Use Bulk operation instead of iteration.
Posted by GitBox <gi...@apache.org>.
bodewig commented on a change in pull request #162:
URL: https://github.com/apache/ant/pull/162#discussion_r720811564
##########
File path: src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java
##########
@@ -294,7 +294,7 @@ public void send() {
? new InternetAddress(addr.getAddress())
: new InternetAddress(addr.getAddress(), name));
}
- return addrs.toArray(new InternetAddress[addrs.size()]);
+ return addrs.toArray(new InternetAddress[0]);
Review comment:
seems to belong to a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #162: Use Bulk operation instead of iteration.
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #162:
URL: https://github.com/apache/ant/pull/162#issuecomment-932934965
thank you @arturobernalg Currently there is a release vote underway and I don't want to disturb things by changing `master` before it is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org