You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/04/22 18:38:09 UTC
[kudu-CR](branch-1.12.x) [webserver-test] fix TestInvalidHeaders on macOS
Hello Hao Hao, Volodymyr Verovkin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15785
to review the following change.
Change subject: [webserver-test] fix TestInvalidHeaders on macOS
......................................................................
[webserver-test] fix TestInvalidHeaders on macOS
Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Reviewed-on: http://gerrit.cloudera.org:8080/15779
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Volodymyr Verovkin <ve...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 2fdda9904aab082207e12325424dd52c5ad7c616)
---
M src/kudu/server/webserver-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/15785/1
--
To view, visit http://gerrit.cloudera.org:8080/15785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Gerrit-Change-Number: 15785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR](branch-1.12.x) [webserver-test] fix TestInvalidHeaders on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15785 )
Change subject: [webserver-test] fix TestInvalidHeaders on macOS
......................................................................
[webserver-test] fix TestInvalidHeaders on macOS
Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Reviewed-on: http://gerrit.cloudera.org:8080/15779
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Volodymyr Verovkin <ve...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 2fdda9904aab082207e12325424dd52c5ad7c616)
Reviewed-on: http://gerrit.cloudera.org:8080/15785
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/server/webserver-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Hao Hao: Looks good to me, approved
Bankim Bhavsar: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Gerrit-Change-Number: 15785
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR](branch-1.12.x) [webserver-test] fix TestInvalidHeaders on macOS
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15785 )
Change subject: [webserver-test] fix TestInvalidHeaders on macOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Gerrit-Change-Number: 15785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 18:53:39 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) [webserver-test] fix TestInvalidHeaders on macOS
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15785 )
Change subject: [webserver-test] fix TestInvalidHeaders on macOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Gerrit-Change-Number: 15785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 18:55:56 +0000
Gerrit-HasComments: No