AW: [PATCH] add 'svn:use-commit-times' property

[Markus Schaber <m....@codesys.com>]

Hi, Martin,

> Von: Philip Martin [mailto:philip.martin@wandisco.com]
> Masaru Tsuchiyama <m....@gmail.com> writes:
> [svn:use_commit_times property]

> Perhaps this property should be inheritable?  Then it could be set on a
> directory and apply to the whole tree?  I imagine users will want that but it
> raises a new problem: how would a node override the inherited property?  It
> can't delete a property that isn't set, and it can't set it as that enables
> use-commit-times.  How would we make inheriting work?
> Perhaps another property svn:no-commit-times?

Using another property is not compatible with inheritance, as it will be difficult to override the setting again in deeper nested directories.

What about disabling the feature when the property contains the test "false"?


Best regards

Markus Schaber

CODESYS(r) a trademark of 3S-Smart Software Solutions GmbH

Inspiring Automation Solutions

3S-Smart Software Solutions GmbH
Dipl.-Inf. Markus Schaber | Product Development Core Technology
Memminger Str. 151 | 87439 Kempten | Germany
Tel. +49-831-54031-979 | Fax +49-831-54031-50

E-Mail: m.schaber@codesys.com | Web: http://www.codesys.com | CODESYS store: http://store.codesys.com
CODESYS forum: http://forum.codesys.com

Managing Directors: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner | Trade register: Kempten HRB 6186 | Tax ID No.: DE 167014915

Re: [PATCH] add 'svn:use-commit-times' property

[Ben Reser <be...@reser.org>]

On Wed, Jul 31, 2013 at 11:19 PM, Markus Schaber <m....@codesys.com> wrote:
> Using another property is not compatible with inheritance, as it will be difficult to override the setting again in deeper nested directories.
>
> What about disabling the feature when the property contains the test "false"?

+1

Inheritable properties need to behave more like the boolean support in
our config rather than the existing property boolean support.  I.E.
explicit true and false values with a default value if a value isn't
specified.

I think it'd be best to introduce this new style of boolean property
only to new svn: properties that we add.  Leave the existing ones as
empty or "*" (actually any value but it's folded to "*" by our
client).  This avoids any breakage with existing users, though I
really don't expect that anyone would set the value to "false"
expecting it to be treated as true.